Ports - Kate and Alex by alexandria7 · Pull Request #20 · Ada-C11/ride-share-rails

alexandria7 · 2019-04-20T00:50:27Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We had three entities, passenger, driver, and trip. Passengers and drivers had many trips, while trips belonged to each of them
Describe the role of model validations in your application	We used validations to require a name, vin, and phone number for drivers and passengers. This prevents us from taking in bad data from the user that could break our code.
How did your team break up the work to be done?	We split passenger and driver functionality, and then worked together on trips. Within trips we split functionality into chunks and worked separately on those.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized basic functionality for creating, editing, deleting drivers, passengers, and trips. We stumbled with dealing with handling the errors that come with deleting a passenger that is part of a trip, which we are submitting without!
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained clarity on RESTful routes - as the project continued, it became more natural to implement changes and introduce more functionality beyond CRUD.
What is your Trello board URL?	https://trello.com/b/dzD1mTBC/rails-rideshare
What is the Heroku URL of your deployed application?	https://ruby-on-roads.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We both agreed that we effectively split the tasks to leverage our different styles of programming. Both of us were doing what we felt best at! It felt good. I think we also realized that being a little more organized at the start of the project would be beneficial when there aren't project waves!

…ip model

…ification to come)

…(validation to come)

Merge? :( (

…viewing trip's cost

CheezItMan · 2019-04-24T03:13:25Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	See my inline notes on extra view files. Good number of commits and both members contributing.
Answered comprehension questions	Check, glad you worked well together
Uses named routes (like `_path`)	Check
RESTful routes utilized	For the most part, see my notes in the routes.rb file
Project Requirements
Table relationships	Check
Business logic is in the models	Some, you could create more methods in the models.
Controller tests	Check, see my notes on things not tested.
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	I can't see the trello board because you didn't make it public!
Heroku instance is online	Check
The app is styled to create an attractive user interface	Some styling in place
Overall	You hit the major learning goals. However you did miss the functionality of requesting a ride and then being unable to request a ride until it's rated. You also don't have a direct way to rate a trip without editing the entire trip.

CheezItMan · 2019-04-24T02:20:23Z

+      }
+
+      expect {
+        post trips_path, params: trip_hash


You don't have a route for the trips_path instead this should post to the passenger_trips_path

CheezItMan · 2019-04-24T02:21:14Z

+  root to: "homepages#index"
+  resources :homepages, only: [:index]
+
+  resources :trips, :drivers, :passengers


You should limit the routes trips has, since there's no new trip form, or a trips show page.

CheezItMan · 2019-04-24T02:23:08Z

+  resources :trips, :drivers, :passengers
+
+  resources :drivers do
+    resources :trips, only: [:index, :new]


Trips shouldn't have a new form page, since the trip is created automatically without a form. You also don't have an index page under the driver's show page.

CheezItMan · 2019-04-24T02:24:15Z

+  end
+
+  resources :passengers do
+    resources :trips, only: [:index, :new]


This should be:

resources :passengers do resources :trips, only: [:create] end

CheezItMan · 2019-04-24T02:24:34Z

+    resources :trips, only: [:index, :new]
+  end
+
+  post "/passengers/:passenger_id/trips/", to: "trips#create", as: "create_passenger_trip"


You can use resources like above to create this.

CheezItMan · 2019-04-24T03:05:14Z

+        patch trip_path(trip_to_update.id), params: trip_hash
+      }.wont_change "Trip.count"
+
+      must_respond_with :redirect


You should also verify that the trip's fields change.

CheezItMan · 2019-04-24T03:05:36Z

  describe "destroy" do
-    # Your tests go here
+    it "can delete a trip" do
+      trip1 = trip


Why assign trip1 to trip?

CheezItMan · 2019-04-24T03:08:43Z

+
+  FEE = 165
+  PERCENTAGE = 0.80
+


Having a go_online method wouldn't be bad.

CheezItMan · 2019-04-24T03:09:20Z

+
+  validates :name, presence: true 
+  validates :phone_num, presence: true, uniqueness: true
+


It would be a good idea to have a request_trip method which generates a trip for an instance of Passenger

CheezItMan · 2019-04-24T03:10:05Z

+  end
+
+  def create
+    @trip = Trip.new(


Some of this business logic could be moved to the Passenger model

alexandria7 and others added 30 commits April 15, 2019 14:46

created new rails project

3655d89

added TripsController

5498ed5

added PassengersController

b3a9627

added DriversController

08e5007

added Driver model

13435c4

added Passenger model

a131f1d

added Trip model

a5bc5ac

added schema and added references to driver_id and passenger_id in Tr…

f0169b8

…ip model

defined associations for each model

0673d2d

this is a new text file on branch called branch-a

a33f060

fixed routes to utilize resources

9bd41ae

Remove spurious model tests

a182dbd

Adds drivers#index

3eadba2

Adds drivers#show

e2d86c1

added list of all passengers to index page

b3ac397

added show page and made each passenger name a link to show

b12c640

Add show and edit for drivers

dd786ce

added corresponding tests for index and show for passengers

c963cc9

list of drivers with links on index page

957a713

Add views for driver

6ba0d59

show.html.erb has edit and delete links

4473010

driver#show has table of trips

6a2e556

added new and create actions as well as corresponding tests (user ver…

6a92778

…ification to come)

added edit and create actions with corresponding tests for passenger …

e803efa

…(validation to come)

added destroy action and corresponding tests

68eab2d

added method for determining total amount charged

db49e91

added validation parameters for passenger

e5338f3

Adds average_rating for driver

7017948

Merge branch 'creating-passenger-functionality'

8183d6b

Merge branch 'master' of https://github.com/alexandria7/ride-share-rails

03a43f3

Merge? :( (

alexandria7 and others added 28 commits April 17, 2019 21:13

added basic actions for trips

f3bc250

more views and edits for trips

759c297

fixed testing let statement for trips and attempted if statement for …

f936559

…viewing trip's cost

changes to drivers view

80d7bc7

changed create method in trip_controller

b6bc311

Merge branch 'master' of https://github.com/alexandria7/ride-share-rails

0e10d89

Merge branch 'master' of https://github.com/alexandria7/ride-share-rails

660abf9

fixed driver tests

a518c54

added error visuals to _form for drivers

fcb4c1f

adds to delete driver

d0a6b1b

Trying a thing

5acbbab

Fixes typo

ae06318

Fixes drivers.controller bug

bb85acd

Add available/availability for drivers

0dc61c5

edited trip controller and view for passengers and drivers

353eb81

removed one link from driver show'

a468571

Adds trip request function to passenger/show

c61d503

Migration adds column for driver active/inactive

6fb7d20

edited routes to include homepages

e999b4c

added edit page for trips

62775d1

fixed tests

df8faa6

fixed tests for trip delete and update

ac81618

added right create method

5a19a0b

Adds passenger active/inactive functionality

1037652

Merge branch 'master' of https://github.com/alexandria7/ride-share-rails

ca4b1b8

fixed tests for all

5e0fed4

fixed merge conflicts

6526105

corrected a failed test that I just noticed was failing

7959965

CheezItMan reviewed Apr 24, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Kate and Alex#20

Ports - Kate and Alex#20
alexandria7 wants to merge 74 commits intoAda-C11:masterfrom
alexandria7:master

alexandria7 commented Apr 20, 2019

Uh oh!

CheezItMan commented Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		validates :name, presence: true
		validates :phone_num, presence: true, uniqueness: true

Conversation

alexandria7 commented Apr 20, 2019

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Apr 24, 2019

Rideshare Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants