Ports - Jessica & Kasey by kaseea · Pull Request #9 · Ada-C11/ride-share-rails

kaseea · 2019-04-19T22:57:01Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trip belongs to Passenger and Trip belongs to Driver. Each Driver has many trips and each Passenger has many Trips. We did it this way to we can access Trips by Passenger or Driver and Passenger or Driver by Trip.
Describe the role of model validations in your application	We required Drivers to have names and vin and Passengers to have names and phone numbers so their information can be complete and professional.
How did your team break up the work to be done?	We did a lot of the project together, and split up the tasks that would be the repetitious parts, being sure each person had a chance to experience coding an aspect at least once, like forms, we each made at least one form, but someone made way more forms than the other.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized all the baseline functions and required features and left all stylizing/CSS til the end.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Restful Routes.
What is your Trello board URL?	https://trello.com/b/UJBuBMqZ/ride-share-rails
What is the Heroku URL of your deployed application?	young-springs-28660.herokuapp.com
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	That we both appreciated the others willingness to work together, so we both have a better understanding of the whole project and code base and how everything works together.

…river#show

…avigation to get to all of them from every page

…hods so they don't store floats

…stead of two identical ones but I don't know how to references it from two different folders)

…ails

…to be changed.

…AND id and added validation for trip

…nger are deleted

…at need to be fixed

…bang)

CheezItMan · 2019-04-24T15:35:55Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	Good number of commits and both partners contributing. Good commit messages & no extra files committed.
Answered comprehension questions	Check
Uses named routes (like `_path`)	Check
RESTful routes utilized	Check, some routes missing and some routes are unnecessarily nested. See my inline comments.
Project Requirements
Table relationships	Check
Business logic is in the models	Check, but see my inline notes. You should make use of enumerable methods.
Controller tests	Check
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Check
Overall	You hit the majority of learning goals. One thing I noticed is that a passenger can still request a ride, even if they have an incomplete trip. Also drivers cannot go online or offline. You did however have the core requirements down. Nice work!

CheezItMan · 2019-04-24T03:28:13Z

+      must_redirect_to drivers_path
+    end
+
+    it "deletes trips associated with driver (but not passenger)" do


CheezItMan · 2019-04-24T15:10:31Z

+  <p><%= "Form for editing a trip" %></p>
+
+  <%= f.label :date %>
+  <%= f.datetime_field :date %>


Just a note, if I use the field to pick a date, I get a front-end validation error.

CheezItMan · 2019-04-24T15:13:33Z

+  resources :drivers
+
+  resources :passengers do
+    resources :trips


You should limit this to only the routes you need, like:

resources :passengers do resources :trips, only [:create] end resources :trips, only [:update, :edit]

CheezItMan · 2019-04-24T15:14:10Z

+  resources :passengers do
+    resources :trips
+  end
+


Missing routes to put a driver online/offline and to mark a trip complete.

CheezItMan · 2019-04-24T15:15:59Z

@@ -0,0 +1,29 @@
+<h2>trips:</h2>


No output of validation errors are here

CheezItMan · 2019-04-24T15:16:55Z

+  def total_charged
+    return 0 if trips.length == 0
+    sum = 0
+    trips.each do |trip|


You can also use the enumerable method .sum

CheezItMan · 2019-04-24T15:17:41Z

+class Trip < ApplicationRecord
+  belongs_to :passenger
+  belongs_to :driver
+


You don't need to write validations for the foreign key relationships. Rails does that by default.

You could also add validations to limit the values that the rating could be, and to limit the cost to be greater than 0.

CheezItMan · 2019-04-24T15:27:02Z

+  has_many :trips
+  validates :name, presence: true
+  validates :phone_num, presence: true
+


I suggest you consider making a request_trip business logic method in the Passenger model here, then you could call it from the controller, and dry up that method

CheezItMan · 2019-04-24T15:30:00Z

+      must_respond_with :redirect
+    end
+
+    it "should respond with a 422 if it doesn't crete" do


kaseea and others added 30 commits April 15, 2019 15:54

ran rails new

7614d6c

Create trips, drivers, and passengers models and Trip controller

f5dcca5

added driver_id and passenger_id to trips and some relevant migrations

def9f1a

Fix driver_id and passenger_id migrations to reference foreign key

4b86cb0

Remove spurious model tests

f63a346

Generate controllers for trips, drivers, and passengers

de23295

Create Homepages controller

d942da7

Add test to TripsController index

e47a826

Create restful routes with resources method

e1eaab2

i have a new commit originally on branch named branch-a

8d6bb9b

I have a commit from a branch

6d0228e

adds listing of all drivers on drivers#index page

10aaa15

creates an appropriate view with required info for driver#index and d…

76128c6

…river#show

Merge branch 'master' of https://github.com/kaseea/ride-share-rails

85793ed

Add form partial and new/edit views with data validation

506bcc6

Fill in passenger controller and index/show pages similarly to driver

d3d3df6

adds validation to passenger model

e316a29

Add features to drivers and passengers show pages

710f035

Merge conflicts

b8ad18a

adds partial forms and new and update forms to passenger, also adds n…

a3fa34c

…avigation to get to all of them from every page

Create button to add new trip to passenger show page and fix some met…

ff28981

…hods so they don't store floats

Merge branch 'master' of https://github.com/kaseea/ride-share-rails

d71148f

Add partial for trips-table (would love to make this the same file in…

600b5d8

…stead of two identical ones but I don't know how to references it from two different folders)

adds trip functionality but not formatting or rating editing

84cd845

Merge branch 'trips_branch' of https://github.com/kaseea/ride-share-r…

e95ecbd

…ails

Add tests for drivers controller

5c5d6bd

Start nesting routes... not finalized. Routes and/or links will need …

11943cf

…to be changed.

Modify routes

91850db

More playing with routes

87fab65

I know its not working, but sharing it so we can split the load

126743b

kaseea and others added 14 commits April 18, 2019 16:02

adds functionality to crete a trip

a0dd81b

some formatting, maybe?

5623728

Create form to edit trip

17f9e1c

Start making drop down for rating

57ef095

Change paths for lots of passenger trips to account for passenger id …

7a9908c

…AND id and added validation for trip

Add drivers controller tests

2ce2264

Add passenger controller tests

595a2a4

Add tests to see if associated trips are deleted when driver or passe…

6ce6dde

…nger are deleted

trips controller test, all working minus a multiple redirect error th…

ce6d9e8

…at need to be fixed

Merge branch 'master' of https://github.com/kaseea/ride-share-rails

6a98c52

Change trips#destroy to redirect to passengers#show page for that trip

9c9cd29

Update trip tests

0dcd56e

Add style with CSS

f12b450

cleans up trip test with let (finally got it working by using create …

4f99118

…bang)

CheezItMan reviewed Apr 24, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Jessica & Kasey#9

Ports - Jessica & Kasey#9
kaseea wants to merge 44 commits intoAda-C11:masterfrom
kaseea:master

kaseea commented Apr 19, 2019

Uh oh!

CheezItMan commented Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

CheezItMan Apr 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kaseea commented Apr 19, 2019

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Apr 24, 2019

Rideshare Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants