Open
Conversation
CheezItMan
reviewed
Sep 10, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work, you hit the learning goals here. Take a look at my comments and let me know if you have any questions.
| def evaluate_postfix(postfix_expression) | ||
| raise NotImplementedError, "Not implemented yet" | ||
| end No newline at end of file | ||
| numbers = { |
| def initialize | ||
| # @store = ... | ||
| raise NotImplementedError, "Not yet implemented" | ||
| @store = [Array.new(QUEUE_SIZE)] |
Author
There was a problem hiding this comment.
WHOOPS! totally a mistake
|
|
||
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| filled_spots = @store.select { |val| val != nil } |
There was a problem hiding this comment.
This is a little bit less efficient than if you started at the front and counted through until you found the rear, or better yet calculated the size.
|
|
||
| def to_s | ||
| return @store.to_s | ||
| adjusted_store = @store.select { |val| val != nil } |
There was a problem hiding this comment.
If the rear wraps around the array, the output here wouldn't be quite right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation