Open
Conversation
CheezItMan
reviewed
Sep 10, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Overall pretty good work. Take a look at my comments on the Queue, but otherwise outstanding work.
| raise NotImplementedError, "Not implemented yet" | ||
| return true if string == "" | ||
|
|
||
| parens_hash = { |
| elsif @front == (@rear + 1) % @store.length # queue is full | ||
| raise Error, "Q full" | ||
| else # queue not empty | ||
| @rear += 1 |
There was a problem hiding this comment.
This needs to be @rear = (@rear + 1) % QUEUE_SIZE because the rear could wrap around the array.
| raise NotImplementedError, "Not yet implemented" | ||
| if @front == -1 # queue is empty | ||
| @front = 0 | ||
| @rear = 0 |
There was a problem hiding this comment.
Starting front and rear at the same number could cause problems if someone tries to dequeue a few times.
|
|
||
| def to_s | ||
| return @store.to_s | ||
| return @store[@front..@rear].to_s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation