Open
Conversation
CheezItMan
reviewed
Sep 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Some issues here with the circular buffer, but overall this is pretty good. Take a look at my comments and let me know where you have questions.
| "{" => "}", | ||
| } | ||
|
|
||
| stack = Stack.new |
| if @front == -1 # Q is empty | ||
| return | ||
|
|
||
| elsif @front == @rear # There's only 1 element |
There was a problem hiding this comment.
When front and rear are equal, the Queue is not empty, it's full.
When they're equal after removing an element, then the queue is empty.
| array = [] | ||
| @store.each_with_index do |element, i| | ||
| next if i < @front | ||
| break if element.nil? |
There was a problem hiding this comment.
What if you've removed 1 element from the front of the queue. Then @store[0] will be nil, and you'll exit the loop early here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation