Skip to content

Hw/master#20

Open
yourFriendWes wants to merge 11 commits intoAda-C4:masterfrom
yourFriendWes:hw/master
Open

Hw/master#20
yourFriendWes wants to merge 11 commits intoAda-C4:masterfrom
yourFriendWes:hw/master

Conversation

@yourFriendWes
Copy link
Copy Markdown

Not finished debugging yet, but starting on cucumber tests for editing categories. Would like feedback on if I fixed previous PR issues correctly : )


def index; redirect_to :action => 'new' ; end
def index
redirect_to :action => 'new' ;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you refactor this code to be more than one line, then you should no longer use semi-colons

@kariabancroft
Copy link
Copy Markdown

When you create a PR you should include a more meaningful title rather than the name of the branch

Given the blog is set up
And I am logged into the admin panel

Scenario: Successfully Add Categories
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants