Skip to content

Tunes Takeout;#21

Open
sophiabaldonado wants to merge 69 commits intoAda-C5:masterfrom
sophiabaldonado:master
Open

Tunes Takeout;#21
sophiabaldonado wants to merge 69 commits intoAda-C5:masterfrom
sophiabaldonado:master

Conversation

@sophiabaldonado
Copy link
Copy Markdown

@sophiabaldonado sophiabaldonado commented May 23, 2016

Sophia Baldonado

SoundChow

I really enjoyed this project and I am super excited about APIs now. I think I did better about not having spaghetti controllers but I'm sure there's still plenty to improve. I should have started testing earlier, I didn't have time to finish my tests.

# Prevent CSRF attacks by raising an exception.
# For APIs, you may want to use :null_session instead.
protect_from_forgery with: :exception
helper_method :current_user, :user_favorited?
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of helper methods!

@brittanykohler
Copy link
Copy Markdown

Overall--great job on this project! I liked your use of descriptive commit messages.

@sophiabaldonado
Copy link
Copy Markdown
Author

@brittanykohler Thanks for the review! It wasn't part of the requirements but I managed to get it deployed to heroku (which was a little bit of a pain in the ass lol) if you want to check it out.. but be prepared to wait 5 minutes between page loads lol slow api is slow.
SoundChow

@brittanykohler
Copy link
Copy Markdown

This is so cool !!!!!!!

On May 24, 2016, at 5:22 PM, sophia notifications@github.com wrote:

@brittanykohler Thanks for the review! It wasn't part of the requirements but I managed to get it deployed to heroku (which was a little bit of a pain in the ass lol) if you want to check it out.. but be prepared to wait 5 minutes between page loads lol slow api is slow.
SoundChow


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants