Open
Conversation
added 10 commits
May 16, 2016 16:16
…it's been awhile.. since I've said I'm sorry.
…es and a better user profile.
…e the unfavorite path happen with the button. currently trying to refactor code in the suggestions controller. if it all goes to shit. revert commit back to this point.
… moved some repetitive shit into private methods in the suggestions controller.
|
|
||
| class Music < ActiveRecord::Base | ||
| def self.search(type, id) | ||
| if type.downcase == "artist" |
There was a problem hiding this comment.
I think this would be a great place to use a case/when statement instead of if/elsif to set the type of search. Both ways work.
|
Great job overall! Your code was easy to read and well written. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here it is.. I didn't do any VCR testing stuff that tests the APIs. I met most of the requirements.