Ruby_Jasmine Kim Trang_MILFs fansite#45
Conversation
…side of the page, not in the main tag
…side of the page, not in the main tag
nancy-harris
left a comment
nancy-harris
left a comment
There was a problem hiding this comment.
Group Fansite
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
✅ |
| All images include alternate text | 😞 |
| No validation errors | 😞 Remember to run your HTML through a validator! |
| CSS | |
| Using class and ID names in style declarations | ✅ |
| Style declarations are DRY | ✅ |
| Overall | 💯 |
|
|
||
| <div id="wrapper"> | ||
| <div class="container"> | ||
| <img src="../assets/mushroom.png" class="shroom" style="--i:21;"></img> |
There was a problem hiding this comment.
All images, even background and decorative ones, need to have alt text. There are standards for how to handle decorative images. The alt text would just be an empty string. For more information, take a look here: https://www.w3.org/WAI/tutorials/images/decorative/
Also, img is a self-closing tag. You do not need a </img> closing tag.
| <li>Have a good trip adventure in Psychedelics on Netflix</li> | ||
| <li><a href="https://www.bbcearth.com/news/8-fantastic-facts-about-fungi/">8 fantastic facts about fungi</a></li> | ||
| <li><a href="https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8514078/">Psychedelics, Sociality, and Human Evolution</a></li> | ||
| <li>Or..you can hit us up and we can go to Colorado</li> |
| <h2 class="item1">Edible</h2> | ||
| <div class="item2"> | ||
| <img class="mushys" src="../assets/Magic_Mushroom_Collection-732x549-Thumbnail.webp"> | ||
| <figcaption>yummy mushrooms</figcaption> |
There was a problem hiding this comment.
If using a figcaption, the image and the caption should be inside a <figure> tag rather than a <div>. See more here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure
| <a href="index.html">Home Page</a></li> | ||
| <a href="facts.html">Fun Facts</a></li> |
There was a problem hiding this comment.
There are closing </li> tags here with no opening <li> tag.
| margin-top: 10px; | ||
| margin-top: 4%; |
There was a problem hiding this comment.
Remember to remove unused properties. Only the second one is being used.
4 participants
No description provided.