You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
most of the time I was trying to figure out what was wrong with the files. It turned out that the message simply contained the ID of only the very first file and assigned it to all the others.
now to display this in the ui I made a check whether a specific id had already been used, this may look like a hard code, but the bug itself is very strange and our architecture with models of individual files does not really suggest that the service could check this when loading. it simply searches for files by 1 and the same id, although in fact all the files that were needed have already been downloaded.
Thanks for the explanation!
Overall it should work, but what do you think to create an additional mini-service for such tasks? It would be much easier to understand in the feature where is the problem and maybe in the future it would be possible to include this service to the tests also
Thanks for the explanation! Overall it should work, but what do you think to create an additional mini-service for such tasks? It would be much easier to understand in the feature where is the problem and maybe in the future it would be possible to include this service to the tests also
I'm not sure that makes sense
in my understanding, if we add a separation of responsibility, we need to refactor the architecture of working with messages containing files, for which we currently do not have the resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MobileIssues specific to iOS or Android appsSwiftiOS-specific code and features in SwiftUX/UIUser interface and experience improvements
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of the time I was trying to figure out what was wrong with the files. It turned out that the message simply contained the ID of only the very first file and assigned it to all the others.
now to display this in the ui I made a check whether a specific id had already been used, this may look like a hard code, but the bug itself is very strange and our architecture with models of individual files does not really suggest that the service could check this when loading. it simply searches for files by 1 and the same id, although in fact all the files that were needed have already been downloaded.