Skip to content

[trello.com/c/pRsTtPYQ] marked each failed files#891

Merged
vovameister merged 1 commit into
release/3.11.0from
trello.com/c/pRsTtPYQ
Aug 18, 2025
Merged

[trello.com/c/pRsTtPYQ] marked each failed files#891
vovameister merged 1 commit into
release/3.11.0from
trello.com/c/pRsTtPYQ

Conversation

@vovameister

Copy link
Copy Markdown
Member

most of the time I was trying to figure out what was wrong with the files. It turned out that the message simply contained the ID of only the very first file and assigned it to all the others.
now to display this in the ui I made a check whether a specific id had already been used, this may look like a hard code, but the bug itself is very strange and our architecture with models of individual files does not really suggest that the service could check this when loading. it simply searches for files by 1 and the same id, although in fact all the files that were needed have already been downloaded.

@Lainaaa

Lainaaa commented Jul 29, 2025

Copy link
Copy Markdown
Member

Thanks for the explanation!
Overall it should work, but what do you think to create an additional mini-service for such tasks? It would be much easier to understand in the feature where is the problem and maybe in the future it would be possible to include this service to the tests also

@vovameister

Copy link
Copy Markdown
Member Author

Thanks for the explanation! Overall it should work, but what do you think to create an additional mini-service for such tasks? It would be much easier to understand in the feature where is the problem and maybe in the future it would be possible to include this service to the tests also

I'm not sure that makes sense
in my understanding, if we add a separation of responsibility, we need to refactor the architecture of working with messages containing files, for which we currently do not have the resources

@vovameister vovameister merged commit d8d3732 into release/3.11.0 Aug 18, 2025
2 checks passed
@vovameister vovameister deleted the trello.com/c/pRsTtPYQ branch August 18, 2025 23:29
@al-onyxprotocol al-onyxprotocol added Mobile Issues specific to iOS or Android apps Swift iOS-specific code and features in Swift UX/UI User interface and experience improvements labels Sep 27, 2025
@al-onyxprotocol al-onyxprotocol added this to the v3.11.0 milestone Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile Issues specific to iOS or Android apps Swift iOS-specific code and features in Swift UX/UI User interface and experience improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug, UX/UI] Incorrect display of unavailable attachments in chat

3 participants