Conversation
al-onyxprotocol
added
bug
al-onyxprotocol
approved these changes
Sep 27, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #919 where sending BTC while a previous transaction is pending incorrectly displays an "Insufficient funds" error instead of the expected "You have an unfinished transaction. Send later" warning. The fix reorders the validation logic to check for pending transactions before attempting to create a new transaction, preventing the BTC transaction creation logic from calculating incorrect available funds when a pending transaction exists.
Changes:
- Moved the pending transaction check (
doesNotContainSendingTx()) to execute beforecreateTransaction()in the Bitcoin wallet transfer flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #919
How to test
Described in the issue
Notes for reviewers
Before we were creating transaction and only after this checking if we have a pending one. I changed the order to check first.
It some magic inside
createTransactionon BTC and somehow it calculate weird (i don't correct or not) when we have pending transaction.