Conversation
metalisk
approved these changes
Jan 20, 2026
Member
|
Do we want this feature? At least now, when we don't even store chats on device (another big task, but not for now). Let's close the pr without merging. |
Member
Author
I also was not sure about it, lets close for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Save chat position after restartring the app. Positions will be deleted on a logout.
Related issue
910
Notes for reviewers
Initially tried to reuse CoreData chatroom, but was not able to implement this approach and decided to use UserDefaults instead.