add access decision task implemented - #60
Merged
Lakes41 merged 3 commits intoJun 28, 2026
Merged
Conversation
Lakes41
approved these changes
Jun 28, 2026
Contributor
There was a problem hiding this comment.
Good Job
@MoscowDev Please do resolve conflicts and pipeline failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Completed
Task Completed
Cache feature implemented, but acceptance-criteria tests cannot be completed due to test harness failure.
Implemented:
apps/access-api/src/services/cacheService.ts
CacheService interface
NoopCacheService (default disabled)
InMemoryCacheService (for unit tests)
apps/access-api/src/services/redisCacheService.ts
Optional Redis-backed CacheService (only used when configured)
apps/access-api/src/config.ts
accessDecisionCacheEnabled (default false)
accessDecisionCacheTtlSeconds (default 30)
accessDecisionCacheVersionTtlSeconds (default 86400)
redisUrl optional (required when caching enabled)
apps/access-api/src/services/memberService.ts
Wired optional access-decision caching into checkAccess
Cache keys include communityId + wallet + resource
Uses per-community version counters to keep invalidation safe
apps/access-api/src/services/accessDecisionCache.test.ts
Added unit tests covering hit/miss/TTL/invalidation logic (in-memory)
Current blocker:
Jest cannot run TypeScript tests because the required transform module ts-jest is not found:
“Module ts-jest in the transform option was not found.”
Net result:
Feature code is in place, but I cannot verify/run the required cache tests in this environment until ts-jest (or an alternative TS Jest transform) is available and working.
coses #56