Skip to content

Fix subscription widgets on main page on Substack-based sites #204052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Apr 26, 2025

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

Add your comment and screenshots

  1. Your comment

Subscription widgets on the main page on Substack-based sites

  1. Screenshots
Screenshot 1:

image

Screenshot 2:

image

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@Alex-302 Alex-302 added the A: In progress Work on the issue is in progress label May 6, 2025
@Alex-302 Alex-302 requested a review from Copilot May 6, 2025 12:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates filter rules to fix subscription widgets on main pages for Substack-based sites by adding additional domains and adjusting the selectors accordingly.

  • Updated the subscription widget rule to include new domains for Substack-based sites.
  • Updated the home-sitemap-signup-form rule to add new domain entries related to subscription feeds.
  • Removed an obsolete subscribe-widget rule for read.engineerscodex.com.
Comments suppressed due to low confidence (2)

AnnoyancesFilter/Popups/sections/subscriptions_specific.txt:36

  • [nitpick] The updated subscription widget rule now includes a long list of domains. Consider verifying the grouping and order to ensure consistency with other rules and to simplify future maintenance.
noahpinion.blog,newcomer.co,blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.techworld-with-milan.com,newsletter.pragmaticengineer.com,newsguardrealitycheck.com,thecoder.cafe,gamefile.news,admissionnotice.com,forbesindia.com,materializedview.io,computerenhance.com,clubstrannik.ru,noktabursa.com.tr,girlonthenet.com,substack.com,santiye.com.tr,rb.ru,investors.com##.subscribe-widget

AnnoyancesFilter/Popups/sections/subscriptions_specific.txt:1426

  • [nitpick] The home-sitemap-signup-form rule now includes several new domains. Please confirm that these additions do not conflict with other filter rules and are placed appropriately to maintain a clear structure.
noahpinion.blog,newcomer.co,blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.techworld-with-milan.com,newsletter.pragmaticengineer.com,substack.com##.home-sitemap-signup-form

@Alex-302
Copy link
Member

Alex-302 commented May 9, 2025

Надо решить конфликты.

rakleed added 2 commits May 9, 2025 18:58
# Conflicts:
#	AnnoyancesFilter/Popups/sections/subscriptions_specific.txt
@rakleed rakleed requested a review from Copilot May 9, 2025 16:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates filter rules to fix subscription widgets on Substack-based sites.

  • Updates the subscribe-widget filter to include new blog domains.
  • Modifies the home-sitemap-signup-form filter to include corresponding new domains while removing an exclusion for read.engineerscodex.com.

@@ -33,7 +33,7 @@ kenh14.vn,ot.gr,sportime.gr,mononews.gr,the-decoder.com,sporx.com,nowymarketing.
! ##.newsletter-popup
corrierenazionale.it,trustedreviews.com,superdeluxeedition.com,schmuckwerk.de,designrush.com,hbr-russia.ru,thewrap.com,reserved.com,citizenwatch.co.uk,mitvergnuegen.com,emergencemagazine.org,afound.com,made.com,elementor.com,infosperber.ch,salzburg-airport.com,michalpasterski.pl##.newsletter-popup
! ##.subscribe-widget
ntv.com.tr,newsguardrealitycheck.com,thecoder.cafe,gamefile.news,admissionnotice.com,forbesindia.com,materializedview.io,computerenhance.com,clubstrannik.ru,noktabursa.com.tr,girlonthenet.com,substack.com,santiye.com.tr,rb.ru,investors.com##.subscribe-widget
noahpinion.blog,newcomer.co,blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.techworld-with-milan.com,newsletter.pragmaticengineer.com,read.engineerscodex.com,ntv.com.tr,newsguardrealitycheck.com,thecoder.cafe,gamefile.news,admissionnotice.com,forbesindia.com,materializedview.io,computerenhance.com,clubstrannik.ru,noktabursa.com.tr,girlonthenet.com,substack.com,santiye.com.tr,rb.ru,investors.com##.subscribe-widget
Copy link
Preview

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider sorting the list of domains alphabetically or grouping them by category to improve readability and ease future maintenance.

Suggested change
noahpinion.blog,newcomer.co,blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.techworld-with-milan.com,newsletter.pragmaticengineer.com,read.engineerscodex.com,ntv.com.tr,newsguardrealitycheck.com,thecoder.cafe,gamefile.news,admissionnotice.com,forbesindia.com,materializedview.io,computerenhance.com,clubstrannik.ru,noktabursa.com.tr,girlonthenet.com,substack.com,santiye.com.tr,rb.ru,investors.com##.subscribe-widget
admissionnotice.com,blog.corkmac.app,blog.sshh.io,clubstrannik.ru,computerenhance.com,forbesindia.com,girlonthenet.com,gamefile.news,hardcoresoftware.learningbyshipping.com,investors.com,materializedview.io,newcomer.co,newsguardrealitycheck.com,newsletter.pragmaticengineer.com,newsletter.techworld-with-milan.com,noahpinion.blog,noktabursa.com.tr,ntv.com.tr,rb.ru,read.engineerscodex.com,santiye.com.tr,substack.com,thecoder.cafe##.subscribe-widget

Copilot uses AI. Check for mistakes.

@@ -1469,7 +1469,7 @@ sport-express.ru##.se-subscribe-block
linuxiac.com##.wp-block-ultimate-post-wrapper
olhardigital.com.br##.newsV2-assinar
olhardigital.com.br##.od-msg-canais
substack.com##.home-sitemap-signup-form
noahpinion.blog,newcomer.co,blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.techworld-with-milan.com,newsletter.pragmaticengineer.com,substack.com##.home-sitemap-signup-form
Copy link
Preview

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider applying a consistent sorting or grouping strategy for the domains in the home-sitemap-signup-form filter to facilitate easier updates in the future.

Suggested change
noahpinion.blog,newcomer.co,blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.techworld-with-milan.com,newsletter.pragmaticengineer.com,substack.com##.home-sitemap-signup-form
blog.corkmac.app,blog.sshh.io,hardcoresoftware.learningbyshipping.com,newsletter.pragmaticengineer.com,newsletter.techworld-with-milan.com,newcomer.co,noahpinion.blog,substack.com##.home-sitemap-signup-form

Copilot uses AI. Check for mistakes.

@Alex-302 Alex-302 merged commit c70f760 into AdguardTeam:master May 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: In progress Work on the issue is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants