Avoid infinite loops in export * from expansion
#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Adjective-Object
commented
Feb 28, 2025
Adjective-Object
commented
- Avoids infinite loop while expanding unresolved external import
- Avoids infinite loop while expanding cyclical imports
- Adds maximum caps to all frontier traversals in graph generation and export * expansion
In f66e808, I added a frontier walk to expand recursive star imports would be resolved to a concrete set of names. However, this had a bug where if a star import into an external package was visited, it would avoid expanding it, and infinitely loop after seeing remaining "*" exports to expand. This commit fixes that by ensuring that we only loop when the expanded exports contain a '*', not when the file contains an unresolved '*' export
Also updates the effectful import expansion logic to be recursive and avoid exporting itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.