Skip to content

feat: add Node24 version and its dependencies #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2025
Merged

feat: add Node24 version and its dependencies #452

merged 2 commits into from
Nov 17, 2025

Conversation

@dthampy
Copy link
Collaborator

@dthampy dthampy commented Nov 14, 2025 •
edited
Loading

Description

Add Nodejs:24 to the list and its dependencies

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dthampy dthampy requested a review from pru55e11 November 14, 2025 15:35
shazron
shazron requested changes Nov 14, 2025
View reviewed changes
Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add link to node-24 dockerhub image in the list: https://hub.docker.com/r/adobeapiplatform/adobe-action-nodejs-v24

@dthampy
Copy link
Collaborator Author

dthampy commented Nov 14, 2025

add link to node-24 dockerhub image in the list: https://hub.docker.com/r/adobeapiplatform/adobe-action-nodejs-v24

Nice catch. updated the list

@dthampy
Copy link
Collaborator Author

dthampy commented Nov 14, 2025

@pru55e11 can you approve this PR if it looks good?

@dthampy dthampy merged commit a83dd00 into main Nov 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shazron shazron shazron approved these changes

@pru55e11 pru55e11 pru55e11 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dthampy @shazron @pru55e11