Skip to content

Added summary table option #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dinogun merged 1 commit into from
Jan 18, 2021
Merged

Added summary table option #491

dinogun merged 1 commit into from
Jan 18, 2021

Conversation

@bharathappali
Copy link
Collaborator

@bharathappali bharathappali commented Dec 28, 2020

Adding a summary table can give a high level view of the docker image build status (built successfully or failed to build)

NOTE: This PR is still a work in progress, will remove WIP tag after it's complete.

Signed-off-by: bharathappali [email protected]

@bharathappali bharathappali marked this pull request as draft December 28, 2020 06:36
@karianna karianna added this to the December 2020 milestone Dec 28, 2020
@bharathappali bharathappali force-pushed the summary-gen branch 2 times, most recently from 3bc05af to e102d36 Compare December 31, 2020 08:24
@bharathappali
Copy link
Collaborator Author

bharathappali commented Dec 31, 2020

Sample output :

+------------------------------------------------------------------------------+----------+
|                                 Docker image                                 |  Status  |
+------------------------------------------------------------------------------+----------+
| adoptopenjdk/openjdk8:x86_64-ubuntu-jdk8u-nightly                            | success  |
+------------------------------------------------------------------------------+----------+

@karianna karianna modified the milestones: December 2020, January 2021 Jan 3, 2021
@bharathappali
Added summary table option
331f42e 
Signed-off-by: bharathappali <[email protected]>
@bharathappali bharathappali marked this pull request as ready for review January 6, 2021 08:17
@bharathappali bharathappali changed the title WIP: Added summary table option Added summary table option Jan 6, 2021
karianna
karianna approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but are there not GitHub or Jenkins build badges or functionality that can be used for this?

dinogun
dinogun approved these changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dinogun dinogun merged commit 137a3c4 into AdoptOpenJDK:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karianna karianna karianna approved these changes

@dinogun dinogun dinogun approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

January 2021

Development

Successfully merging this pull request may close these issues.

3 participants

@bharathappali @karianna @dinogun