Fixed path issue for summary table

[bharathappali]

Earlier the path was incorrect and as a result the jenkins job log was missing the summary table. The file is now created at the root dir (i.e openjdk-docker) and will be updated by the build_image function to log the docker build status. In the end the table is displayed and the temporary file .summary_table is deleted.

@dinogun Can i please have it reviewed ? Thanks in advance.

Signed-off-by: bharathappali [email protected]

[dinogun]

Looking at the summary_table related functions, I think thee is no need for them to be in common_functions.sh as it is only used in build_latest.sh. I think it would be better to move all of the functions to build_latest.sh, then you wont need to recompute summary_table_file in multiple places.

[bharathappali]

@dinogun Thanks for your review. Earlier I have added summary table related functions in common_functions.sh file thinking it can be used anywhere in build_latest or build_all but you were right it makes sense to add them in build_all.sh where they are being used in the current implementation. I have made the changes accordingly. Can i please have the latest changes reviewed ?

[dinogun]

I'd suggest rm -f as it is just a file

[bharathappali]

Aah! I shouldn't have added a recursive option. Changed it to rm -f

[dinogun]

You can define it here and export it so that you dont have to redefine in build_latest.sh. In build_latest.sh you can check if it is not set and set it only if needed.

[bharathappali]

Made changes accordingly. Had also exported root_dir in build_all.sh

[dinogun]

lgtm