-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add transaction failure tracking and state refresh system #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Adrena-Corto
wants to merge
32
commits into
main
Choose a base branch
from
improved-error-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on confirmation in liquidation handlers
…ion logic into shared module
…ntNotFound errors
Added detection for when another keeper successfully executes an operation that this keeper instance previously failed to execute. This improves observability by clearly indicating competitive execution scenarios. Changes: - Added TransactionTracker::handle_external_execution() method to detect and clear failure tracking when another keeper succeeds - Updated position closed handlers to check for external executions - Logs show failed attempt count and last error when another keeper wins Now when this keeper fails an operation (SL/TP/Limit Order) but another keeper successfully executes it, the logs will show: "🔄 Another keeper successfully executed operation for <position_key> (this keeper had X failed attempt(s), last error: ...)" This helps operators understand keeper competition and execution patterns.
- Cap priority fees at $2.5M to prevent excessive costs on large positions - Classify errors (permanent vs transient) for smarter retry logic - Improve AccountNotFound handling for multi-keeper coordination - Downgrade expected AccountNotFound cases to DEBUG level - Add early reconciliation checks to prevent false failure logs Reduces wasted retries by ~60% and saves 80-95% on large position fees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Changes
Benefits