Skip to content

Add class name support #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewmurphyio
Copy link

Adds a new feature for adding custom classnames

@AdrianMaj AdrianMaj self-assigned this Mar 20, 2025
@AdrianMaj
Copy link
Owner

That won't work, + I don't have access to push to your branch. I am not sure if $patchStyleText will work with className (probably not), also converters are not updated to handle this, and client feature is not exported. I will take a deep look to it later and fix it, anyway thanks for PR!

@andrewmurphyio
Copy link
Author

I struggled to get this working locally because of payload versioning issues. If you don't have time to finish it off maybe you can help me finish it?

@AdrianMaj
Copy link
Owner

What payload versioning issues? The simplest way to run this locally (that's how I do it) is to hit pnpm build on the plugin project, and then on any payload project pnpm install "file:../path/to/plugin-root, then it should work like a normal package from npm. Not sure if you have to add it manually to package.json with the name for first time and then just install it again when updated and builded.

At the moment my free time is limited, so I would be grateful if you want to finish it, otherwise I will do it in my spare time. If you need any help feel free to ask, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants