Skip to content

Card scanning - integrate scanning library#2045

Merged
atmamont merged 17 commits intoCOIOS-826_OCR_featurefrom
feature/OCR-integrate-framework
Mar 13, 2025
Merged

Card scanning - integrate scanning library#2045
atmamont merged 17 commits intoCOIOS-826_OCR_featurefrom
feature/OCR-integrate-framework

Conversation

@atmamont
Copy link
Copy Markdown
Contributor

@atmamont atmamont commented Mar 10, 2025

Summary

This change finally makes use of AdyenCardScanner

Demo

Not available for privacy reasons (card data)

Release notes

COIOS-827

TODO

  • discuss error handling (errors mapping and UX on the app side) after initial phase of internal testing

@atmamont atmamont changed the base branch from develop to COIOS-826_OCR_feature March 10, 2025 11:07
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@atmamont atmamont added the chore a pull request that has chore changes that shouldn't be in the release notes label Mar 10, 2025
Comment thread AdyenCard/Components/Card/CardViewController.swift Outdated
Comment thread AdyenCard/Components/Card/CardViewController.swift Outdated
Comment thread AdyenCard/Form/FormCardNumberItemView.swift
Comment thread AdyenCardScanner/Sources/CardScannerAssembler.swift
Comment thread AdyenCard/Components/Card/CardViewController.swift
Comment thread AdyenCard/Components/Card/CardViewController.swift Outdated
Comment thread AdyenCardScanner/Sources/CardScannerAssembler.swift
Comment thread AdyenCard/Components/Card/CardViewController.swift Outdated
@goergisn goergisn requested review from erenbesel and goergisn March 11, 2025 16:15
Comment thread AdyenCard/Components/Card/CardViewController.swift Outdated
Comment thread AdyenCard/Components/Card/CardViewController.swift Outdated
@github-actions
Copy link
Copy Markdown
Contributor

✅ No changes detected

Comparing feature/OCR-integrate-framework to COIOS-826_OCR_feature


Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
21.9% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@atmamont atmamont merged commit a5c4ad9 into COIOS-826_OCR_feature Mar 13, 2025
13 of 14 checks passed
@atmamont atmamont deleted the feature/OCR-integrate-framework branch March 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a pull request that has chore changes that shouldn't be in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants