Skip to content

Skipping release job instead of succeeding without action #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goergisn merged 1 commit into from
Mar 14, 2025
Merged

Skipping release job instead of succeeding without action #2055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .github/workflows/create_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
create_release:
if: github.event.pull_request.merged == true
if: github.event.pull_request.merged == true && startsWith(github.event.pull_request.head.ref, 'release/')
name: "Create Release"
runs-on: ubuntu-latest

Expand All @@ -20,24 +20,13 @@ jobs:
run: |
SOURCE_BRANCH=${{ github.event.pull_request.head.ref }}

# Checking if the source branch was a release
# If the branch is not a release branch we return early and skip the subsequent steps
if [[ "$SOURCE_BRANCH" != release/* ]]; then
echo "PROCEED=false" >> $GITHUB_ENV
echo "Source branch does not match pattern. Exiting."
echo "IS_RELEASE_BRANCH=false" >> $GITHUB_ENV
exit 0
fi

# Extracting the version number from the source branch name
# If the version number does not match we fail to indicate an issue
VERSION_NUMBER=${SOURCE_BRANCH#release/}
if [[ ! "$VERSION_NUMBER" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "'$VERSION_NUMBER' does not match semantic versioning format. Exiting."
exit 1
fi

echo "IS_RELEASE_BRANCH=true" >> $GITHUB_ENV

MERGE_COMMIT_SHA=${{ github.event.pull_request.merge_commit_sha }}
PR_NUMBER=${{ github.event.pull_request.number }}
Expand All @@ -56,7 +45,6 @@ jobs:
echo "$PR_BODY" >> "${{ github.workspace }}/release_content.md"

- name: Create Release
if: env.IS_RELEASE_BRANCH == 'true'
uses: softprops/action-gh-release@v2
with:
body_path: "${{ github.workspace }}/release_content.md"
Expand Down
Loading