Skip to content

Update access controls#2060

Merged
nauaros merged 5 commits intoCOIOS-826_OCR_featurefrom
update-access-controls
Mar 19, 2025
Merged

Update access controls#2060
nauaros merged 5 commits intoCOIOS-826_OCR_featurefrom
update-access-controls

Conversation

@nauaros
Copy link
Copy Markdown
Contributor

@nauaros nauaros commented Mar 17, 2025

Summary

  • Add missing access controls.
  • Exclude AdyenCardScanner tests from linting.

Ticket

COIOS-000

@nauaros nauaros added the chore a pull request that has chore changes that shouldn't be in the release notes label Mar 17, 2025
@nauaros nauaros self-assigned this Mar 17, 2025
@nauaros nauaros requested review from atmamont and erenbesel March 17, 2025 11:59
Copy link
Copy Markdown
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was late on the previous PR that had 2 small typos. Maybe can update them here

Comment thread .swiftlint.yml
Comment thread AdyenCardScanner/Sources/ROIView.swift
Copy link
Copy Markdown
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your base branch not aligned with this branch? Why do we see the AdyenNetworking change comment 🤔

@github-actions
Copy link
Copy Markdown
Contributor

✅ No changes detected

Comparing update-access-controls to COIOS-826_OCR_feature


Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@sonarqubecloud
Copy link
Copy Markdown

@nauaros nauaros merged commit 847d98b into COIOS-826_OCR_feature Mar 19, 2025
12 checks passed
@nauaros nauaros deleted the update-access-controls branch March 19, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a pull request that has chore changes that shouldn't be in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants