Closed
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
# Summary Update AdyenCardScanner podspec ## Checklist [Required] <!-- Mark completed items with an [x] --> - [x] Tested changes locally - [x] Added/updated unit tests - [x] Verified against acceptance criteria
Add write access to post release job ## Checklist [Required] <!-- Mark completed items with an [x] --> - [x] Tested changes locally - [x] Added/updated unit tests - [x] Verified against acceptance criteria --------- Co-authored-by: Naufal Aros <naufal.aros@adyen.com>
atmamont
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
ℹ️ No baseline data found for 'develop'.
|
Contributor
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
|
atmamont
requested review from
a team,
descorp and
erenbesel
and removed request for
a team
descorp
reviewed
Oct 17, 2025
| # componentsEnvironment | ||
| sed -i '' "s/static let componentsEnvironment.*=.*/static let componentsEnvironment = Environment.$ENVIRONMENT/g" ./Demo/Configuration.swift | ||
| # Environment is now configured via xcconfig and Info.plist | ||
| echo "Using ENVIRONMENT=$ENVIRONMENT setting from configuration" |
Contributor
There was a problem hiding this comment.
The whole step "⚙️ Configure Demo App" is no longer needed, right ?
Contributor
Author
There was a problem hiding this comment.
This is a very good point, @descorp ! Thanks for catching
Contributor
Author
|
Hasn't been picked up for a few months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [Required]
Demo [Required for UI changes]
Ticket [Optional]
COSDK-585Todo
checkout/{version}/delete/storedPaymentMethods/(storedPaymentMethodId)(remove stored payment methods)Checklist [Required]