Threeds2Component theme migration - AdyenTheme to ADYAppearanceConfiguration#2462
Merged
robertdalmeida merged 18 commits intodevelopfrom Mar 30, 2026
Merged
Threeds2Component theme migration - AdyenTheme to ADYAppearanceConfiguration#2462robertdalmeida merged 18 commits intodevelopfrom
robertdalmeida merged 18 commits intodevelopfrom
Conversation
…eConfiguration Replace ADYAppearanceConfiguration parameter with AdyenTheme across all ThreeDS2 action handlers and components. Add appearanceConfigurationFromAdyenTheme conversion function (currently returns default configuration). Remove appearanceConfiguration from ThreeDS2ActionConfiguration as it's now derived from theme.
…ppearance configuration Introduce ADYAppearanceConfigurationBuilder that transforms AdyenTheme into ADYAppearanceConfiguration for the 3DS2 SDK. Replace appearanceConfiguration parameter with theme across all ThreeDS2 action handlers and components. Update FingerprintServiceParameters to use AdyenTheme instead of ADYAppearanceConfiguration. The builder maps colors, fonts, and styles from AdyenTheme to corresponding 3DS2 SDK appearance properties,
Change infoAppearance.headingFont and infoAppearance.headingTextColor to use labels.body instead of labels.title for consistency with the text properties.
…eckoutConfiguration object
robertdalmeida
added
the
chore
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
ℹ️ No baseline data found for 'develop'.
|
robertdalmeida
changed the title
…n-ios into chore/threeds-theme-migration
Robert-SD
reviewed
Mar 26, 2026
Contributor
|
| 🔀 | 1 Modification |
AdyenActions
ThreeDS2ActionConfiguration
🔀 Modified
// From
public init()
// To
public init(theme: AdyenUI.AdyenTheme = .default)
/**
Changes:
- Added parameter `theme: AdyenUI.AdyenTheme = .default`
*/Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay
Contributor
|
Great effort |
atmamont
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [Required]
An initial version to migrate AdyenTheme to ADYAppearanceConfiguration. -> The
ADYAppearanceConfigurationBuilder: Note this is not perfect and finalized, there is still some dicussions i need to have with Android and Arjen about this mapping, and it is based on best effort right now. Will iterate on this, but those changes can be more targeted and specific.Passing AdyenTheme to ThreeDS2Component, even in the default configuration - i think theme is minimally required. @erenbesel please confirm this part specifically.
Took the liberty to add a test app configuration to switch some themes. I can remove this if not required, but thought this would be something good to have for the test app in general. Especially during development.
Demo [Required for UI changes]
Simulator.Screen.Recording.-.co-v6-.16+.26.1.-.2026-03-25.at.15.42.44.mov
Simulator.Screen.Recording.-.co-v6-.16+.26.1.-.2026-03-25.at.15.43.46.mov
Simulator.Screen.Recording.-.co-v6-.16+.26.1.-.2026-03-25.at.15.47.36.mov
Simulator.Screen.Recording.-.co-v6-.16+.26.1.-.2026-03-25.at.15.49.00.mov
Ticket [Optional]
COSDK-1099
Checklist [Required]