Skip to content

Co-badge changes Pt 1#2472

Merged
erenbesel merged 9 commits intofeature/co-badge_basefrom
feature/co-badge_work
Apr 3, 2026
Merged

Co-badge changes Pt 1#2472
erenbesel merged 9 commits intofeature/co-badge_basefrom
feature/co-badge_work

Conversation

@erenbesel
Copy link
Copy Markdown
Contributor

@erenbesel erenbesel commented Mar 31, 2026

Summary [Required]

  • Adds the selection mechanism back to DualBrandAccessoryView with the new design. Not used by the component yet.
  • Move DualBrandAccessoryView out of being nested in FormCardNumberItemView
Screen.Recording.2026-04-03.at.13.57.48.mov

Ticket [Optional]

COSDK-1064

Checklist [Required]

  • Tested changes locally
  • Added/updated unit tests
  • Verified against acceptance criteria

- Adds the selection mechanism back to DualBrandAccessoryView with the new design. Not used by the component yet.
- Move DualBrandAccessoryView out of being nested in FormCardNumberItemView
@erenbesel erenbesel requested a review from atmamont March 31, 2026 13:00
@erenbesel erenbesel added the chore a pull request that has chore changes that shouldn't be in the release notes label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026

ℹ️ No baseline data found for 'feature/co-badge_base'.

Framework Size
AdyenComponents.framework 2753 KB
AdyenActions.framework 2939 KB
AdyenDropIn.framework 1281 KB
AdyenDelegatedAuthentication.framework 82 KB
AdyenAuthentication.framework 347 KB
AdyenWeChatPay.framework 257 KB
AdyenCardScanner.framework 710 KB
AdyenEncryption.framework 517 KB
AdyenSession.framework 855 KB
AdyenTwint.framework 271 KB
AdyenWeChatPayInternal.framework 4135 KB
AdyenCashAppPay.framework 1773 KB
AdyenCard.framework 1737 KB
TwintSDK.framework 97 KB
Adyen3DS2.framework 919 KB
Adyen.framework 7566 KB
total 26239 KB

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the DualBrandAccessoryView into a standalone internal class and implements a segmented picker interface for dual-branded cards. The update introduces brand selection logic, including visual feedback through shadows and borders, and adds gesture recognizers to handle user interaction. Additionally, a new componentSegmentedBackground color was added to the core styles, and integration tests were expanded to verify the new selection behavior and appearance states. One review comment suggests ensuring that CALayer border colors are manually updated in traitCollectionDidChange to correctly support theme changes.

Comment thread AdyenCard/Form/DualBrandAccessoryView.swift Outdated
Comment thread Adyen/UI/Styles/CoreColors.swift Outdated
Comment thread Tests/IntegrationTests/Card Tests/DualBrandAccessoryViewTests.swift Outdated
Comment thread Tests/IntegrationTests/Card Tests/DualBrandAccessoryViewTests.swift Outdated
Comment thread Tests/IntegrationTests/Card Tests/DualBrandAccessoryViewTests.swift
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift Outdated
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift Outdated
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift Outdated
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift Outdated
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift
New cobadge UI is big and won’t fit textfield without increasing the gap between title and text. so we make the view clip through
And clean up DualBrandAccessoryView
Comment thread AdyenCard/Form/DualBrandAccessoryView.swift
Comment thread AdyenCard/Form/FormCardNumberItemView.swift
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

✅ No changes detected

Comparing feature/co-badge_work to feature/co-badge_base


Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

@erenbesel erenbesel merged commit 1a84bea into feature/co-badge_base Apr 3, 2026
8 of 10 checks passed
@erenbesel erenbesel deleted the feature/co-badge_work branch April 3, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a pull request that has chore changes that shouldn't be in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants