StoredCard and Preselected screen amount based changes & tests#2479
StoredCard and Preselected screen amount based changes & tests#2479robertdalmeida merged 15 commits intodevelopfrom
Conversation
|
ℹ️ No baseline data found for 'develop'.
|
There was a problem hiding this comment.
Code Review
This pull request refines localization strings by removing payment amount information from security code descriptions and preselected payment method subtitles, updating LocalizationKey.swift and Localizable.strings accordingly. It also introduces a new localizedSubmitButtonTitle helper function and adjusts its usage in StoredCardInputViewModel.swift and PreselectedPaymentMethodViewModel.swift. UI layout changes in StoredCardInputViewController.swift include modified content padding and updated Auto Layout constraints. The review identifies a potential Auto Layout ambiguity in StoredCardInputViewController and points out that redundant arguments are being passed to localization functions in StoredCardInputViewModel.subtitleText and PreselectedPaymentMethodViewModel.swift due to the updated string formats. Unit tests for StoredCardInputViewModel and PreselectedPaymentMethodIntegrationTests were refactored and expanded to cover various amount scenarios and align with the new localization logic.
…itle localization
… in StoredCardInputViewController
…dyen-ios into chore/stored-view-ui-adjustments
…s for improved readability
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay |
Summary [Required]
Checklist [Required]