Skip to content

StoredCard and Preselected screen amount based changes & tests#2479

Merged
robertdalmeida merged 15 commits intodevelopfrom
chore/stored-view-ui-adjustments
Apr 15, 2026
Merged

StoredCard and Preselected screen amount based changes & tests#2479
robertdalmeida merged 15 commits intodevelopfrom
chore/stored-view-ui-adjustments

Conversation

@robertdalmeida
Copy link
Copy Markdown
Contributor

@robertdalmeida robertdalmeida commented Apr 2, 2026

Summary [Required]

  • Amount can have 3 states, so added tests for them using existing copies(note: the copies may change but that will be a smaller change). The todo for this change will still remain until it is confirmed.
  • Fixing contraints for the width and duplicate constraints for the StoredView.
  • Passing CheckoutTheme to the StoredCardComponent
  • Removing unused code in the viewModel.

Checklist [Required]

  • Tested changes locally
  • Added/updated unit tests

@robertdalmeida robertdalmeida self-assigned this Apr 2, 2026
@robertdalmeida robertdalmeida added the chore a pull request that has chore changes that shouldn't be in the release notes label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

ℹ️ No baseline data found for 'develop'.

Framework Size
AdyenComponents.framework 2790 KB
AdyenActions.framework 2395 KB
AdyenDropIn.framework 1359 KB
AdyenDelegatedAuthentication.framework 98 KB
AdyenAuthentication.framework 347 KB
AdyenWeChatPay.framework 262 KB
AdyenUI.framework 3311 KB
AdyenCardScanner.framework 694 KB
AdyenEncryption.framework 504 KB
AdyenSession.framework 750 KB
AdyenTwint.framework 278 KB
AdyenWeChatPayInternal.framework 4135 KB
AdyenCheckout.framework 2070 KB
AdyenCashAppPay.framework 1764 KB
AdyenCard.framework 1747 KB
TwintSDK.framework 97 KB
Adyen3DS2.framework 919 KB
Adyen.framework 5065 KB
total 28585 KB

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines localization strings by removing payment amount information from security code descriptions and preselected payment method subtitles, updating LocalizationKey.swift and Localizable.strings accordingly. It also introduces a new localizedSubmitButtonTitle helper function and adjusts its usage in StoredCardInputViewModel.swift and PreselectedPaymentMethodViewModel.swift. UI layout changes in StoredCardInputViewController.swift include modified content padding and updated Auto Layout constraints. The review identifies a potential Auto Layout ambiguity in StoredCardInputViewController and points out that redundant arguments are being passed to localization functions in StoredCardInputViewModel.subtitleText and PreselectedPaymentMethodViewModel.swift due to the updated string formats. Unit tests for StoredCardInputViewModel and PreselectedPaymentMethodIntegrationTests were refactored and expanded to cover various amount scenarios and align with the new localization logic.

Comment thread Adyen/Assets/Generated/LocalizationKey.swift
Comment thread Adyen/Assets/Generated/LocalizationKey.swift
Comment thread AdyenCard/Components/Stored Card/StoredCardComponent.swift Outdated
Comment thread Adyen/Assets/en-US.lproj/Localizable.strings
Comment thread Tests/IntegrationTests/Card Tests/StoredCardComponentTests.swift
Comment thread Tests/IntegrationTests/Card Tests/StoredCardInputViewModelTests.swift Outdated
Comment thread Tests/IntegrationTests/Card Tests/StoredCardInputViewModelTests.swift Outdated
@robertdalmeida robertdalmeida requested a review from atmamont April 13, 2026 11:10
@github-actions
Copy link
Copy Markdown
Contributor

✅ No changes detected

Comparing chore/stored-view-ui-adjustments to develop


Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay

@robertdalmeida robertdalmeida merged commit d07f6da into develop Apr 15, 2026
15 checks passed
@robertdalmeida robertdalmeida deleted the chore/stored-view-ui-adjustments branch April 15, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a pull request that has chore changes that shouldn't be in the release notes size:small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants