Conversation
nauaros
added
the
chore
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
ℹ️ No baseline data found for 'v5'.
|
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
| internal let version: String | ||
|
|
||
| internal let channel: String = "iOS" | ||
| internal let channel: String = "ios" |
There was a problem hiding this comment.
Will this conflict with our existing data collection? Is case sensitivity important?
| private let lock = NSLock() | ||
|
|
||
| @_spi(AdyenInternal) | ||
| public func override(version: String, platform: Platform) { |
There was a problem hiding this comment.
Can we rename override into overrideForCrossPlatform to use the same name as Android has?
There was a problem hiding this comment.
Shall we also order the parameter accordingly?
There was a problem hiding this comment.
yeah, I can order it exactly like Android has it
|
|
||
| public private(set) var version: String = adyenSdkVersion | ||
| public private(set) var platform: Platform = .ios | ||
| public let channel: String = "ios" |
There was a problem hiding this comment.
The channel is initialized in AnalyticsData and AnalyticsRequest. Shall we use one central public constant?
2 participants
Summary
This PR introduces some key changes related with
SDKData:SDKDatain order to support hosted checkout components. These are:channelplatformsdkVersionpaymentMethodBehaviorchannelandplatformneeds to be lowercase. Thus, every instance ofiOShas been replaced withios.CheckoutPlatformParams. Similar to Android, there's a centralized place where cross-platform can override platform parameteters such asversionandchannel.Ticket
COSDK-1149Checklist