Skip to content

Remove AuthenticationComponent Handling of ThreeDS2FingerprintAction & ThreeDS2ChallengeAction (part 3/4)#2502

Merged
robertdalmeida merged 3 commits intodevelopfrom
chore/remove-authentication-classic-actions
Apr 22, 2026
Merged

Remove AuthenticationComponent Handling of ThreeDS2FingerprintAction & ThreeDS2ChallengeAction (part 3/4)#2502
robertdalmeida merged 3 commits intodevelopfrom
chore/remove-authentication-classic-actions

Conversation

@robertdalmeida
Copy link
Copy Markdown
Contributor

Summary [Required]

  1. Removed the support of ThreeDS2FingerprintAction & ThreeDS2ChallengeAction
  2. Marked some types to package

Whats next?

  • Handle pending todos on this topic & some optimizations of the AuthenticationComponent(Like removal of some redundant data types). (keeping this MR solely for deletion)

COSDK-1100

Checklist [Required]

  • Tested changes locally
  • Added/updated unit tests

Previous PR

@robertdalmeida robertdalmeida self-assigned this Apr 21, 2026
@robertdalmeida robertdalmeida added the chore a pull request that has chore changes that shouldn't be in the release notes label Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

ℹ️ No baseline data found for 'develop'.

Framework Size
AdyenComponents.framework 2790 KB
AdyenActions.framework 2374 KB
AdyenDropIn.framework 1359 KB
AdyenDelegatedAuthentication.framework 98 KB
AdyenAuthentication.framework 347 KB
AdyenWeChatPay.framework 262 KB
AdyenUI.framework 3311 KB
AdyenCardScanner.framework 694 KB
AdyenEncryption.framework 504 KB
AdyenSession.framework 750 KB
AdyenTwint.framework 278 KB
AdyenWeChatPayInternal.framework 4135 KB
AdyenCheckout.framework 2093 KB
AdyenCashAppPay.framework 1764 KB
AdyenCard.framework 1747 KB
TwintSDK.framework 97 KB
Adyen3DS2.framework 919 KB
Adyen.framework 5065 KB
total 28587 KB

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy 3DS2 "classic" flow, deleting ThreeDS2ClassicActionHandler and consolidating 3DS2 actions. Feedback identifies a potential regression where paymentData is no longer propagated in 3DS2 actions, resulting in nil values in integration tests. Additionally, suggestions were made to use package visibility for ThreeDSResult and the Error enum to maintain consistency with the AuthenticationComponent and facilitate cross-module access.

Comment thread AdyenActions/Components/Authentication/ThreeDSResult.swift
Comment thread AdyenActions/Components/Authentication/AuthenticationComponent.swift Outdated
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ 4 public changes detected ⚠️

Comparing chore/remove-authentication-classic-actions to develop

4 Removals

Adyen

Action

❌ Removed

case threeDS2Challenge(Adyen.ThreeDS2ChallengeAction)
case threeDS2Fingerprint(Adyen.ThreeDS2FingerprintAction)

AdyenActions

❌ Removed

public enum ThreeDS2Details: Adyen.AdditionalDetails
public struct ThreeDSResult: Swift.Decodable

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay

@robertdalmeida robertdalmeida marked this pull request as ready for review April 22, 2026 07:47
Copy link
Copy Markdown
Contributor

@erenbesel erenbesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@robertdalmeida robertdalmeida merged commit e56b836 into develop Apr 22, 2026
15 checks passed
@robertdalmeida robertdalmeida deleted the chore/remove-authentication-classic-actions branch April 22, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a pull request that has chore changes that shouldn't be in the release notes size:medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants