Remove StoredCardAlertManager and switch to using StoredCardInputViewController by robertdalmeida · Pull Request #2503 · Adyen/adyen-ios

robertdalmeida · 2026-04-22T11:34:07Z

Summary [Required]

Remove StoredCardAlertManager and switch to using StoredCardInputViewController

Whats next?

Fix bug 🐞 Constraints issue with the FormCardSecurityCodeItemView.
Fix bug 🐞 ScrollView not working with the keyboard.
Fix bug 🐞 Amex card should accept 4 digits
Fix bug 🐞 Validation issue with the FormCardSecurityItem - it accepts 4 digits even though UI accepts only 3.

COSDK-1140

Checklist [Required]

Tested changes locally
Added/updated unit tests
Verified against acceptance criteria

…tead of alert-based UI

…toredCardInputViewModel

…oredCardInputViewController to PreselectedPaymentMethodRouter

…roperty in StoredCardInputViewModel

…InputViewController verification test. As these tests are duplicated in StoredCardInputViewModel tests

…r as navigation is now handled by PreselectedPaymentMethodRouter

…onstant in StoredCardInputViewModel and PreselectedPaymentMethod tests

…per for UI interaction instead of direct UIAlertController manipulation

…y and add TODO for AMEX CVC length handling

…stored-view-reduced-scope

…r instead of UIAlertController

gemini-code-assist

Code Review

This pull request replaces the StoredCardAlertManager, which utilized a UIAlertController, with a new StoredCardInputViewController and StoredCardInputViewModel for processing stored card payments. The changes include project file updates, deprecation of related localization keys, and adjustments to the Drop-in routing logic. Feedback indicates that the removal of the back button logic prevents dismissal in standalone mode, a regression exists where the pay button is enabled without a security code, and a required analytics event call is missing in the new implementation.

gemini-code-assist · 2026-04-22T11:35:31Z

        configureContent()
        setupBindings()
-        setupNavigationBackButton()
        disableSwipeDownToDismissScreen()


The removal of the back button logic (setupNavigationBackButton and backTapped) makes the StoredCardInputViewController non-dismissible when used as a standalone component. While the PreselectedPaymentMethodRouter in Drop-in now handles this manually, other consumers of StoredCardComponent will find the UI stuck. Furthermore, the closeHandler defined in StoredCardComponent is no longer triggered by any UI action within this view controller, rendering it unreachable.

gemini-code-assist · 2026-04-22T11:35:31Z


        XCTAssertTrue(proxy.securityCodeText?.isEmpty == true)
-        XCTAssertFalse(proxy.isPayButtonEnabled)
+        XCTAssertTrue(proxy.isPayButtonEnabled)


The test assertion for isPayButtonEnabled has been changed from false to true while the security code is empty. This indicates a regression in validation logic; the pay button should remain disabled until a valid security code is entered, consistent with the previous implementation.

gemini-code-assist · 2026-04-22T11:35:31Z

+            self?.viewController.dismiss(animated: true)
+        }
+
+        self.sendInitialAnalytics()


The call to sendDidLoadEvent() is missing in the new viewController initialization. This event was present in the previous StoredCardAlertManager implementation and is typically required for accurate analytics tracking when the component is loaded.

Suggested change

self.sendInitialAnalytics()

self.sendInitialAnalytics()

self.sendDidLoadEvent()

github-actions · 2026-04-22T11:36:06Z

ℹ️ No baseline data found for 'develop'.

Framework	Size
AdyenComponents.framework	2822 KB
AdyenActions.framework	2374 KB
AdyenDropIn.framework	1362 KB
AdyenDelegatedAuthentication.framework	98 KB
AdyenAuthentication.framework	347 KB
AdyenWeChatPay.framework	262 KB
AdyenUI.framework	3311 KB
AdyenCardScanner.framework	694 KB
AdyenEncryption.framework	504 KB
AdyenSession.framework	750 KB
AdyenTwint.framework	278 KB
AdyenWeChatPayInternal.framework	4135 KB
AdyenCheckout.framework	2100 KB
AdyenCashAppPay.framework	1764 KB
AdyenCard.framework	1715 KB
TwintSDK.framework	97 KB
Adyen3DS2.framework	919 KB
Adyen.framework	5066 KB
total	28598 KB

…validation and fix loading state handling

…n true after submit

github-actions · 2026-04-22T12:52:47Z

⚠️ 9 public changes detected ⚠️

Comparing chore/connect-the-stored-view-reduced-scope to develop

❇️	5 Additions
❌	4 Removals

`AdyenComponents`

❇️ Added

public protocol ApplePayAuthorizationDelegate: AnyObject {
  func didAuthorize(
    payment: PassKit.PKPayment,
    completion: @escaping (PassKit.PKPaymentAuthorizationResult) -> Swift.Void
  ) -> Swift.Void
}

public protocol ApplePayComponentDelegate: AnyObject {
  func didUpdate(
    contact: PassKit.PKContact,
    for summaryItems: [PassKit.PKPaymentSummaryItem],
    completion: @escaping (PassKit.PKPaymentRequestShippingContactUpdate) -> Swift.Void
  ) -> Swift.Void
  func didUpdate(
    couponCode: Swift.String,
    for summaryItems: [PassKit.PKPaymentSummaryItem],
    completion: @escaping (PassKit.PKPaymentRequestCouponCodeUpdate) -> Swift.Void
  ) -> Swift.Void
  func didUpdate(
    shippingMethod: PassKit.PKShippingMethod,
    for summaryItems: [PassKit.PKPaymentSummaryItem],
    completion: @escaping (PassKit.PKPaymentRequestShippingMethodUpdate) -> Swift.Void
  ) -> Swift.Void
}

`ApplePayComponent`

❇️ Added

@_Concurrency.MainActor
weak public var applePayDelegate: (any AdyenComponents.ApplePayComponentDelegate)?

@_Concurrency.MainActor
weak public var authorizationDelegate: (any AdyenComponents.ApplePayAuthorizationDelegate)?

`ApplePayComponent.Configuration`

❇️ Added

public var dismissesAutomatically: Swift.Bool

❌ Removed

public var onAuthorize: (@_Concurrency.MainActor (PassKit.PKPayment) async -> PassKit.PKPaymentAuthorizationResult)?

public var onCouponCodeChange: (@_Concurrency.MainActor (Swift.String, [PassKit.PKPaymentSummaryItem]) async -> PassKit.PKPaymentRequestCouponCodeUpdate)?

public var onShippingContactChange: (@_Concurrency.MainActor (PassKit.PKContact, [PassKit.PKPaymentSummaryItem]) async -> PassKit.PKPaymentRequestShippingContactUpdate)?

public var onShippingMethodChange: (@_Concurrency.MainActor (PassKit.PKShippingMethod, [PassKit.PKPaymentSummaryItem]) async -> PassKit.PKPaymentRequestShippingMethodUpdate)?

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCardScanner, AdyenCashAppPay, AdyenCheckout, AdyenComponents, AdyenDelegatedAuthentication, AdyenDropIn, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenUI, AdyenWeChatPay

robertdalmeida added 12 commits April 16, 2026 16:57

Refactor StoredCardComponent to use StoredCardInputViewController ins…

a77683f

…tead of alert-based UI

Remove StoredCardAlertManager and add custom localization tests for S…

1d476a8

…toredCardInputViewModel

Remove StoredCardAlertManager and move navigation back button from St…

3689784

…oredCardInputViewController to PreselectedPaymentMethodRouter

Remove test extension for accessing private storedCardPaymentMethod p…

5f51c48

…roperty in StoredCardInputViewModel

Remove obsolete stored card alert controller tests and add StoredCard…

56e28d9

…InputViewController verification test. As these tests are duplicated in StoredCardInputViewModel tests

Remove back navigation button tests from StoredCardInputViewControlle…

4d70e57

…r as navigation is now handled by PreselectedPaymentMethodRouter

Replace hardcoded bullet characters with String.Adyen.securedString c…

cdebedd

…onstant in StoredCardInputViewModel and PreselectedPaymentMethod tests

Refactor StoredCardComponentTests to use StoredCardComponentProxy hel…

a7aed2f

…per for UI interaction instead of direct UIAlertController manipulation

Refactor StoredCardComponent CVC tests to use StoredCardComponentProx…

84addac

…y and add TODO for AMEX CVC length handling

Merge remote-tracking branch 'origin/develop' into chore/connect-the-…

687b50b

…stored-view-reduced-scope

Merge remote-tracking branch 'origin/develop' into chore/connect-the-…

9123391

…stored-view-reduced-scope

Refactor StoredCardComponentProxy to use StoredCardInputViewControlle…

75eb7c6

…r instead of UIAlertController

robertdalmeida self-assigned this Apr 22, 2026

robertdalmeida added the chore a pull request that has chore changes that shouldn't be in the release notes label Apr 22, 2026

github-actions Bot added the size:small label Apr 22, 2026

github-actions Bot approved these changes Apr 22, 2026

View reviewed changes

gemini-code-assist Bot reviewed Apr 22, 2026

View reviewed changes

Refactor StoredCardInputViewModel to support card brand-specific CVC …

d3ae8c3

…validation and fix loading state handling

github-actions Bot added the size:medium label Apr 22, 2026

Update StoredCardInputViewModelTests to expect loading state to remai…

f2448ab

…n true after submit

robertdalmeida closed this Apr 23, 2026

robertdalmeida deleted the chore/connect-the-stored-view-reduced-scope branch April 23, 2026 07:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove StoredCardAlertManager and switch to using StoredCardInputViewController#2503

Remove StoredCardAlertManager and switch to using StoredCardInputViewController#2503
robertdalmeida wants to merge 14 commits intodevelopfrom
chore/connect-the-stored-view-reduced-scope

robertdalmeida commented Apr 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	self.sendInitialAnalytics()
	self.sendInitialAnalytics()
	self.sendDidLoadEvent()

Conversation

robertdalmeida commented Apr 22, 2026

Summary [Required]

Checklist [Required]

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

⚠️ 9 public changes detected ⚠️

AdyenComponents

❇️ Added

ApplePayComponent

❇️ Added

ApplePayComponent.Configuration

❇️ Added

❌ Removed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Apr 22, 2026 •

edited

Loading

`AdyenComponents`

`ApplePayComponent`

`ApplePayComponent.Configuration`