Skip to content

Generate Configuration/ACS/Transfer/Transaction/Dispute webhooks and add Balance webhooks #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 13, 2025
Merged

Generate Configuration/ACS/Transfer/Transaction/Dispute webhooks and add Balance webhooks #1494

merged 7 commits into from
May 13, 2025

Conversation

gcatanese
Copy link
Contributor

@gcatanese gcatanese commented May 8, 2025 •
edited
Loading

Generate webhooks models

Add new Balance Webhooks

The previous enum values were annotated incorrectly. This PR addresses this

Configuration Webhooks

  • Add replacedById to PaymentInstrument

AcsWebhooks

  • Enum value has changed:

    • Before: OTP_SMS
    • After: PWD_OTP_PHONE_FL - OTP flow via SMS

  • Enum value has changed:

    • Before: OOB
    • After: OOB_TRIGGER_FL - Out-of-band trigger flow

  • New:

    • Added PWD_OTP_EMAIL_FL - OTP flow via Email

@gcatanese gcatanese requested a review from a team as a code owner May 8, 2025 12:37
@gcatanese gcatanese force-pushed the generate-webhooks-models branch 2 times, most recently from 57ac061 to 3bcd141 Compare May 12, 2025 14:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Kwok-he-Chu
Kwok-he-Chu reviewed May 13, 2025
View reviewed changes
Copy link
Member

@Kwok-he-Chu Kwok-he-Chu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, added comments related to adding extra info in the description

@gcatanese gcatanese enabled auto-merge May 13, 2025 11:57
@gcatanese gcatanese force-pushed the generate-webhooks-models branch from 3bcd141 to da3ec7d Compare May 13, 2025 11:57
@gcatanese gcatanese disabled auto-merge May 13, 2025 12:03
@gcatanese gcatanese merged commit 7cc1838 into main May 13, 2025
@gcatanese gcatanese deleted the generate-webhooks-models branch May 13, 2025 12:03
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwok-he-Chu Kwok-he-Chu Kwok-he-Chu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcatanese @Kwok-he-Chu