Conversation
Contributor
|
Ah, yes, there are many such cases, e.g., in tmp-checker branch, I added a function let essentially_slice lid =
let (|>) x f = f x in
[
[ "std"; "path" ], "Path";
[ "std"; "ffi"; "os_str" ], "OsStr";
]
|> List.mem lidBut I don't think we should handle them by hand by ourselves, ultimately, after the mono migration, we will be able to know their metadata and translate as The problem now is just that in the generic case like This is how I understand it, but might be wrong, would you have a deeper explanation to your intention if this is not what you mean? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ssyram this is a WIP -- I tried to extract more code from the
strmoduleI think in the long run, we will want a mechanism to encode some type equations for when things have the same representation, like you have done on your branch -- this is one case where we have to know that str is a slice of u8, and it looks based on your branch that there are more such cases