Skip to content

Conversation

@tarkah
Copy link
Contributor

@tarkah tarkah commented Mar 7, 2024

Comment on lines -227 to 230
pub enum Error {
#[error("Root is invalid")]
#[error("root is invalid")]
RootInvalid,
#[error("Cache dir is invalid")]
#[error("cache directory is invalid")]
CacheInvalid,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should our root library errors start capitalized or lowercase? 🤔 And then should all context be lowercase? Consistency here lends towards a nicer UX

@tarkah tarkah force-pushed the feat/better-errors branch from d45bfb4 to 82be174 Compare March 7, 2024 23:20
@ermo ermo added type: documentation Improvements or additions to documentation. type: enhancement (PR) New feature delivered as a PR labels May 14, 2024
@ermo ermo added this to the zz -- deferred milestone May 14, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@ermo ermo added the type: user experience Will make for a nicer user experience label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation Improvements or additions to documentation. type: enhancement (PR) New feature delivered as a PR type: user experience Will make for a nicer user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants