boulder: use /usr/bin/bash for script shebangs #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermo
force-pushed
the
use-usr-bin-bash-for-script-shebangs
branch
3 times, most recently
from
87cb3b9 to
9d32dc5
Compare
Add helix, less and ripgrep to buildroots for chroot purposes. TODO: This really ought to be user-controlled as a boulder config option, along with optionally copying in the current user's `~/.gitconfig` to the boulder buildroot for easier patching in chroots. Signed-off-by: Rune Morling <[email protected]>
With this change, the build scripts generated by boulder from the stone.yaml recipes are no longer affected by the /usr/bin/sh symlink, which means that we can now safely point that to dash for a potential increase of up to +20% faster configure runs for e.g. gettext. This commit also creates dedicated *_with_bash fallback autotools actions which should ensure that stubborn packages whose build systems rely on the presence of a bash shell can now simply use the *_with_bash actions. Signed-off-by: Rune Morling <[email protected]>
Signed-off-by: Rune Morling <[email protected]>
ermo
force-pushed
the
use-usr-bin-bash-for-script-shebangs
branch
from
9d32dc5 to
d3d27d1
Compare
ermo
changed the title
|
@ReillyBrogan I'm going cross-eyed looking at these macros. Would you mind giving them a quick once over for sanity before I merge this? |
Signed-off-by: Rune Morling <[email protected]>
ermo
force-pushed
the
use-usr-bin-bash-for-script-shebangs
branch
from
d3d27d1 to
3a72595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the build scripts generated by boulder from the stone.yaml recipes are no longer affected by the /usr/bin/sh symlink, which means that we can now safely point that to dash for a potential increase of up to +20% faster configure runs for e.g. gettext.
This commit also creates dedicated *_with_bash fallback autotools actions which should ensure that stubborn packages whose build systems rely on the presence of a bash shell can now simply use the *_with_bash actions.
In addition, add helix, less and ripgrep to roots for a nicer chroot experience when troubleshooting or writing/testing patches inside the chroot (yes, this is a really nice workflow actually).
TODO: The extra chroot packages really ought to be user-controlled (with a decent, if minimal fallback) as a boulder config option, along with optionally copying in the current user's .gitconfig to the root for easier patching inside chroots. See #476 for the details.