Update nix to v0.31.2 & associated API changes#718
Draft
joebonrichie wants to merge 1 commit intomainfrom
Draft
Conversation
joebonrichie
force-pushed
the
nix-0.31.2
branch
5 times, most recently
from
07722de to
cd2ece8
Compare
No longer NO_FOLLOW_SYMLINK in linkat() in blit_element_item to prevent EINVAL errors. This mirrors what was previously required for io-uring and rustix experiments. Avoid using deprecated flock API and adjust as neccessary linkat now needs directory fds passed to it to more closly match the syscall, adjust as neccessary. No longer close() after entering a new container, this appears to no longer be neccessary now we're using an &OwnedFd instead of i32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer NO_FOLLOW_SYMLINK in linkat() in blit_element_item to prevent EINVAL errors. This mirrors what was previously required for io-uring and rustix experiments.
Avoid using deprecated flock API and adjust as neccessary
linkat now needs directory fds passed to it to more closly match the syscall, adjust as neccessary.