fix: photo viewer logic to use filtered photos for opening #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
|
@ChrAlpha is attempting to deploy a commit to the innei-dev Team on Vercel. A member of the Team first needs to authorize it. |
Copilot finished reviewing on behalf of
ChrAlpha
November 20, 2025 04:33
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the photo viewer logic to use filtered photos when opening a specific photo from a URL. Previously, the viewer index was calculated from the unfiltered master photo list, causing the wrong photo to display when URL-driven filters were active.
Key Changes:
- Removed unused
photoLoaderimport after transitioning togetFilteredPhotos() - Reordered photo viewer opening to occur after filter state is set, ensuring filters are applied before index calculation
- Changed from
photoLoader.getPhotos()togetFilteredPhotos()for index calculation, aligning with the filtered photo list used by the viewer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Innei
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change now derives the target index from
getFilteredPhotos(), which mirrors the photo list thatusePhotoViewerconsumes. Previously, the index came fromphotoLoader.getPhotos()(the unfiltered master list), so opening the viewer after URL-driven filters could point to the wrong photo.Kapture.2025-11-20.at.12.26.12.mp4
This PR edit keeps viewer state aligned with the filtered gallery and prevents mismatched indices.
Kapture.2025-11-20.at.12.28.02.mp4