feat(photo-processing): implement location processing and geocoding system #95

missuo · 2025-09-05T00:32:59Z

Summary

This PR enhances the display of location information by showing the geographical name instead of just raw latitude and longitude coordinates. It integrates the free [Nominatim](https://nominatim.org/) API to perform reverse geocoding.

For a detailed preview of the changes, please refer to: https://vincent.ac/IMG_0306

Changes

Feature: Use the Nominatim API to fetch human-readable geographical names based on latitude and longitude.
UI Update: Locations are now displayed as descriptive names when available, improving readability and user experience.
New Environment Variables:
- NOMINATIM_ACCEPT_LANGUAGE → Sets the preferred language for location names.
  - Default: en
- VITE_SHOW_DETAILED_LOCATION → Controls the granularity of the displayed location:
  - If set to true, shows detailed location names (e.g., street, neighborhood, etc.).
  - If set to false, only shows the city-level location.
  - Default: false

…ystem Add comprehensive location processing pipeline including EXIF GPS extraction, coordinate validation, and Nominatim reverse geocoding with caching support. Enhance photo metadata with location data and improve ExifPanel display. Add geocode cache file to .gitignore to exclude generated data from tracking.

- Updated Nominatim reverse geocoding to include a display name in the response. - Modified the ExifPanel to conditionally show detailed location based on the new environment variable. - Adjusted location formatting logic to accommodate East Asian language order. - Added displayName field to relevant types and processing functions for improved location representation.

Enter-tainer · 2025-09-06T12:46:27Z

.env.template

+
+NOMINATIM_ACCEPT_LANGUAGE=en
+VITE_SHOW_DETAILED_LOCATION=true


consider using config.json instead of env? https://github.com/Afilmory/afilmory/blob/main/config.example.json

or builder.config.json

we should remove this since we already use config.json

use builder.config.json instead

Enter-tainer · 2025-09-06T12:47:40Z

packages/builder/src/lib/geo/coords.ts

@@ -0,0 +1,36 @@
+import type { PickedExif } from '../../types/photo.js'
+
+export function convertExifGPSToDecimal(


i remember there is already a function for this

Can we use convertExifGPSToDecimal in apps/web/src/lib/map-utils.ts ?

Enter-tainer · 2025-09-06T12:49:07Z

packages/builder/src/lib/geocoding/nominatim.ts

+  if (existing) return existing
+
+  const p = schedule(async () => {
+    const url = `https://nominatim.openstreetmap.org/reverse?lat=${encodeURIComponent(


https://operations.osmfoundation.org/policies/nominatim/ nominatim requires a 1 qps limit for its api

- Introduced geocoding settings in builder and site configurations, allowing for customizable language preferences. - Updated ExifPanel to utilize site configuration for displaying detailed location based on user settings. - Enhanced example configuration files to reflect new options for geocoding and UI display preferences.

missuo · 2025-09-06T15:32:39Z

I have fixed the above issues. acceptLanguage is placed in builder.config.json, while showDetailedLocation, which controls the rendering of the front-end page, is placed in config.json.

Also, the frequency of requests to the Nominatim API has been strictly controlled.

Please check the code again, thank you.

Enter-tainer · 2025-09-09T02:26:12Z

.env.template

+
+NOMINATIM_ACCEPT_LANGUAGE=en
+VITE_SHOW_DETAILED_LOCATION=true


we should remove this since we already use config.json

Enter-tainer · 2025-09-09T02:29:32Z

apps/web/src/components/ui/photo-viewer/ExifPanel.tsx

+    const isEastAsiaOrder =
+      activeLang.startsWith('zh') ||
+      activeLang.startsWith('ja') ||
+      activeLang === 'jp'


how about ko?

Enter-tainer · 2025-09-09T02:29:41Z

apps/web/src/components/ui/photo-viewer/ExifPanel.tsx

+    const isEastAsiaOrder =
+      activeLang.startsWith('zh') ||
+      activeLang.startsWith('ja') ||
+      activeLang === 'jp'


Enter-tainer · 2025-09-09T02:31:02Z

apps/web/src/components/ui/photo-viewer/ExifPanel.tsx

+    return isEastAsiaOrder ? parts.join(' ') : parts.join(', ')
+  }, [currentPhoto])


iirc in China we don't use space to separate address. like 辽宁省沈阳市. But i guess depends on the result of the api call. I'm open to discussion.

Enter-tainer · 2025-09-09T02:33:38Z

packages/builder/src/lib/geocoding/nominatim.ts

+  address?: Record<string, string>
+}
+
+const CACHE_FILE = path.join(workdir, 'src/data/.geocode-cache.json')


TODO for reviewer: why do we need a new cache file. Any recommendation? Would it be possible to directly use manifest

Enter-tainer · 2025-09-09T02:34:22Z

packages/builder/src/lib/geocoding/nominatim.ts

+
+type NominatimResponse = {
+  display_name?: string
+  address?: Record<string, string>


nit: consider using a more accurate type hint for this?

I think it's okay to use manifest, scanning the corresponding fields in builder can detect whether cache data exists.

Enter-tainer · 2025-09-09T02:35:20Z

packages/builder/src/lib/geocoding/nominatim.ts

+  }
+}
+
+const roundCoord = (n: number, decimals = 3) => Number(n.toFixed(decimals))


Enter-tainer · 2025-09-09T02:37:36Z

packages/builder/src/photo/image-pipeline.ts

+      location: await processLocation(
+        exifData,
+        photoKey,
+        existingItem,
+        options,
+      ),


Please add an option to disable reverse geoencoding. Due to the rate limit, it would be extremely slow to build manifest for users with many photos

Innei · 2025-09-13T13:51:14Z

@codex review code and summary this pr changes, what feature want to implement?

chatgpt-codex-connector · 2025-09-13T13:51:22Z

@codex review code and summary this pr changes, what feature want to implement?

For now, I can only help with PRs you've created.

Innei · 2025-09-13T13:52:49Z

@copilot review code and summary this pr changes, what feature want to implement?

Innei · 2025-09-13T13:56:01Z

.env.template

+
+NOMINATIM_ACCEPT_LANGUAGE=en
+VITE_SHOW_DETAILED_LOCATION=true


use builder.config.json instead

Innei · 2025-09-13T13:56:28Z

.gitignore

 apps/web/assets-git
 apps/web/public/thumbnails
 apps/web/src/data/photos-manifest.json
+apps/web/src/data/.geocode-cache.json


.geocode-cache.json should upload to remote repo cache

Innei · 2025-09-13T13:58:01Z

packages/builder/src/lib/geocoding/nominatim.ts

+
+type NominatimResponse = {
+  display_name?: string
+  address?: Record<string, string>


I think it's okay to use manifest, scanning the corresponding fields in builder can detect whether cache data exists.

missuo added 2 commits September 5, 2025 07:50

Enter-tainer reviewed Sep 6, 2025

View reviewed changes

Innei requested a review from Enter-tainer September 8, 2025 12:36

Enter-tainer reviewed Sep 9, 2025

View reviewed changes

Innei requested changes Sep 13, 2025

View reviewed changes


		NOMINATIM_ACCEPT_LANGUAGE=en
		VITE_SHOW_DETAILED_LOCATION=true

		@@ -0,0 +1,36 @@
		import type { PickedExif } from '../../types/photo.js'

		export function convertExifGPSToDecimal(

		return isEastAsiaOrder ? parts.join(' ') : parts.join(', ')
		}, [currentPhoto])

feat(photo-processing): implement location processing and geocoding system #95

Are you sure you want to change the base?

feat(photo-processing): implement location processing and geocoding system #95

Uh oh!

Conversation

missuo commented Sep 5, 2025

Summary

Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

missuo commented Sep 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Innei commented Sep 13, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 13, 2025

Uh oh!

Innei commented Sep 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants