Skip to content

test: expand event publish helper coverage - #1016

Open
LyViolz wants to merge 1 commit into
Agent-Field:mainfrom
LyViolz:tests/event-publish-helpers
Open

test: expand event publish helper coverage#1016
LyViolz wants to merge 1 commit into
Agent-Field:mainfrom
LyViolz:tests/event-publish-helpers

Conversation

@LyViolz

@LyViolz LyViolz commented Aug 31, 2026

Copy link
Copy Markdown

Summary

Testing

  • GOTOOLCHAIN=go1.25.0 go test ./internal/events/... -count=1
  • GOTOOLCHAIN=go1.25.0 go test -race ./internal/events/... -count=1
  • git diff --check
  • internal/events coverage: 87.0% -> 97.2%

Fixes #394

@LyViolz
LyViolz requested review from a team and AbirAbbas as code owners August 31, 2026 07:24
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage gate

Thresholds from .coverage-gate.toml: per-surface ≥ 84%, aggregate ≥ 85%, max per-surface regression ≤ 1.0 pp, max aggregate regression ≤ 0.50 pp.

Surface Current Baseline Δ
control-plane 87.60% 87.40% ↑ +0.20 pp 🟡
sdk-go 93.00% 92.00% ↑ +1.00 pp 🟢
sdk-python 94.31% 93.73% ↑ +0.58 pp 🟢
sdk-typescript 91.68% 90.42% ↑ +1.26 pp 🟢
web-ui 84.76% 84.79% ↓ -0.03 pp 🟡
aggregate 85.81% 85.75% ↑ +0.06 pp 🟡

✅ Gate passed

No surface regressed past the allowed threshold and the aggregate stayed above the floor.

@github-actions

Copy link
Copy Markdown
Contributor

📐 Patch coverage gate

Threshold: 80% on lines this PR touches vs origin/main (from .coverage-gate.toml:thresholds.min_patch).

Surface Touched lines Patch coverage Status
control-plane 0 ➖ no changes
sdk-go 0 ➖ no changes
sdk-python 0 ➖ no changes
sdk-typescript 0 ➖ no changes
web-ui 0 ➖ no changes

✅ Patch gate passed

Every surface whose lines were touched by this PR has patch coverage at or above the threshold.

@santoshkumarradha

Copy link
Copy Markdown
Member

I spot-checked the new event coverage locally and it looks fine, and the full CI surface is now green. At this point the remaining blockers are repo state rather than test content: license/cla is still pending, and after #1014 and #1015 landed this branch is now conflicting with current main. Please rebase on the latest main, rerun the checks, and once the CLA is signed this should be in good shape for a final pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Control Plane] Add tests for internal/events publish helpers (node/exec/reasoner)

3 participants