fix(agentfield): add test for issue #825 - #833
Draft
Salomondiei08 wants to merge 1 commit into
Draft
Conversation
|
Jay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Ref: Agent-Field#825 Signed-off-by: Jay <sallomondiei@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test intended to cover issue #825 around Agent.run server argument handling in the Python SDK.
Changes:
- Added
tests/test_issue_825.pyto validateAgent.runbehavior in “server mode”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,32 @@ | |||
| """Regression coverage for issue #825: ``Agent.run`` server arguments.""" | |||
Comment on lines
+24
to
+32
| monkeypatch.setattr( | ||
| sys, | ||
| "argv", | ||
| ["agent.py", "--port", "8765", "--host", "127.0.0.1", "--dev"], | ||
| ) | ||
|
|
||
| Agent.run(app) | ||
|
|
||
| assert served_with == {"port": 8765, "host": "127.0.0.1", "dev": True} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds test coverage for the behavior described in issue #825.
Why
Fixes #825
Testing