Ci/dependabot consolidation#140
Conversation
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.6.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@40f1582...4a36011) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.35.0 to 0.36.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@57a97c7...ed142fd) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.6.0 to 6.0.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@b9fd7d1...57e3a13) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…p/otelhttp Bumps the mcp-proxy-go-modules group in /services/mcp-proxy with 1 update: [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib). Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.63.0 to 0.68.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.63.0...zpages/v0.68.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp dependency-version: 0.68.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: mcp-proxy-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dorny/paths-filter](https://github.com/dorny/paths-filter) from 6852f92c20ea7fd3b0c25de3b5112db3a98da050 to d1c1ffe0248fe513906c8e24db8ea791d46f8590. - [Release notes](https://github.com/dorny/paths-filter/releases) - [Changelog](https://github.com/dorny/paths-filter/blob/master/CHANGELOG.md) - [Commits](dorny/paths-filter@6852f92...d1c1ffe) --- updated-dependencies: - dependency-name: dorny/paths-filter dependency-version: d1c1ffe0248fe513906c8e24db8ea791d46f8590 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the services-processor-go-modules group in /services/processor with 2 updates: [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) and [github.com/segmentio/kafka-go](https://github.com/segmentio/kafka-go). Updates `github.com/ClickHouse/clickhouse-go/v2` from 2.40.3 to 2.46.0 - [Release notes](https://github.com/ClickHouse/clickhouse-go/releases) - [Changelog](https://github.com/ClickHouse/clickhouse-go/blob/main/CHANGELOG.md) - [Commits](ClickHouse/clickhouse-go@v2.40.3...v2.46.0) Updates `github.com/segmentio/kafka-go` from 0.4.50 to 0.4.51 - [Release notes](https://github.com/segmentio/kafka-go/releases) - [Commits](segmentio/kafka-go@v0.4.50...v0.4.51) --- updated-dependencies: - dependency-name: github.com/ClickHouse/clickhouse-go/v2 dependency-version: 2.46.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: services-processor-go-modules - dependency-name: github.com/segmentio/kafka-go dependency-version: 0.4.51 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: services-processor-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the services-ingest-go-modules group in /services/ingest with 2 updates: [github.com/segmentio/kafka-go](https://github.com/segmentio/kafka-go) and [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib). Updates `github.com/segmentio/kafka-go` from 0.4.50 to 0.4.51 - [Release notes](https://github.com/segmentio/kafka-go/releases) - [Commits](segmentio/kafka-go@v0.4.50...v0.4.51) Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.63.0 to 0.68.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.63.0...zpages/v0.68.0) --- updated-dependencies: - dependency-name: github.com/segmentio/kafka-go dependency-version: 0.4.51 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: services-ingest-go-modules - dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp dependency-version: 0.68.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: services-ingest-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the example-server-go-modules group in /examples/go-mcp-server with 1 update: [github.com/modelcontextprotocol/go-sdk](https://github.com/modelcontextprotocol/go-sdk). Updates `github.com/modelcontextprotocol/go-sdk` from 1.4.1 to 1.6.0 - [Release notes](https://github.com/modelcontextprotocol/go-sdk/releases) - [Commits](modelcontextprotocol/go-sdk@v1.4.1...v1.6.0) --- updated-dependencies: - dependency-name: github.com/modelcontextprotocol/go-sdk dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: example-server-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
…p/otelhttp Bumps the services-ui-go-modules group in /services/ui with 1 update: [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib). Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.63.0 to 0.68.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.63.0...zpages/v0.68.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp dependency-version: 0.68.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: services-ui-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the services-api-go-modules group in /services/api with 2 updates: [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) and [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib). Updates `github.com/ClickHouse/clickhouse-go/v2` from 2.40.3 to 2.46.0 - [Release notes](https://github.com/ClickHouse/clickhouse-go/releases) - [Changelog](https://github.com/ClickHouse/clickhouse-go/blob/main/CHANGELOG.md) - [Commits](ClickHouse/clickhouse-go@v2.40.3...v2.46.0) Updates `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` from 0.63.0 to 0.68.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.63.0...zpages/v0.68.0) --- updated-dependencies: - dependency-name: github.com/ClickHouse/clickhouse-go/v2 dependency-version: 2.46.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: services-api-go-modules - dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp dependency-version: 0.68.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: services-api-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the root-go-modules group with 10 updates: | Package | From | To | | --- | --- | --- | | [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) | `2.40.3` | `2.46.0` | | [github.com/pterm/pterm](https://github.com/pterm/pterm) | `0.12.82` | `0.12.83` | | [github.com/spf13/cobra](https://github.com/spf13/cobra) | `1.8.0` | `1.10.2` | | [go.uber.org/zap](https://github.com/uber-go/zap) | `1.27.0` | `1.27.1` | | [golang.org/x/term](https://github.com/golang/term) | `0.41.0` | `0.42.0` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.28.4` | `0.36.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.28.4` | `0.36.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.28.4` | `0.36.0` | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.16.3` | `0.24.0` | | [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) | `1.3.0` | `1.6.0` | Updates `github.com/ClickHouse/clickhouse-go/v2` from 2.40.3 to 2.46.0 - [Release notes](https://github.com/ClickHouse/clickhouse-go/releases) - [Changelog](https://github.com/ClickHouse/clickhouse-go/blob/main/CHANGELOG.md) - [Commits](ClickHouse/clickhouse-go@v2.40.3...v2.46.0) Updates `github.com/pterm/pterm` from 0.12.82 to 0.12.83 - [Release notes](https://github.com/pterm/pterm/releases) - [Commits](pterm/pterm@v0.12.82...v0.12.83) Updates `github.com/spf13/cobra` from 1.8.0 to 1.10.2 - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.0...v1.10.2) Updates `go.uber.org/zap` from 1.27.0 to 1.27.1 - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.27.0...v1.27.1) Updates `golang.org/x/term` from 0.41.0 to 0.42.0 - [Commits](golang/term@v0.41.0...v0.42.0) Updates `k8s.io/api` from 0.28.4 to 0.36.0 - [Commits](kubernetes/api@v0.28.4...v0.36.0) Updates `k8s.io/apimachinery` from 0.28.4 to 0.36.0 - [Commits](kubernetes/apimachinery@v0.28.4...v0.36.0) Updates `k8s.io/client-go` from 0.28.4 to 0.36.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.28.4...v0.36.0) Updates `sigs.k8s.io/controller-runtime` from 0.16.3 to 0.24.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.16.3...v0.24.0) Updates `sigs.k8s.io/yaml` from 1.3.0 to 1.6.0 - [Release notes](https://github.com/kubernetes-sigs/yaml/releases) - [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/yaml@v1.3.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/ClickHouse/clickhouse-go/v2 dependency-version: 2.46.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: github.com/pterm/pterm dependency-version: 0.12.83 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: root-go-modules - dependency-name: github.com/spf13/cobra dependency-version: 1.10.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: go.uber.org/zap dependency-version: 1.27.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: root-go-modules - dependency-name: golang.org/x/term dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: k8s.io/api dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: k8s.io/apimachinery dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: k8s.io/client-go dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules - dependency-name: sigs.k8s.io/yaml dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: root-go-modules ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 7.0.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...043fb46) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…s/setup-go-6.4.0' into ci/dependabot_consolidation
…s/upload-artifact-7.0.1' into ci/dependabot_consolidation
…curity/trivy-action-0.36.0' into ci/dependabot_consolidation
…v/codecov-action-6.0.0' into ci/dependabot_consolidation
…paths-filter-d1c1ffe0248fe513906c8e24db8ea791d46f8590' into ci/dependabot_consolidation
…dules-2cb5809231' into ci/dependabot_consolidation
…o-mcp-server/example-server-go-modules-76733c8582' into ci/dependabot_consolidation
…pi/services-api-go-modules-33fb4907ae' into ci/dependabot_consolidation
…ngest/services-ingest-go-modules-60e703af38' into ci/dependabot_consolidation
…cp-proxy/mcp-proxy-go-modules-bff2f57579' into ci/dependabot_consolidation
…rocessor/services-processor-go-modules-d84b33228a' into ci/dependabot_consolidation
…i/services-ui-go-modules-bff2f57579' into ci/dependabot_consolidation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Code Review
This pull request refactors the API scheme registration and webhook validation logic to use newer controller-runtime patterns and generic interfaces. It also includes a major update of project dependencies, upgrading Go to 1.26.0 and Kubernetes libraries to 0.36.0. Feedback focuses on the webhook implementations where the oldObj parameter is incorrectly ignored during update validations, which prevents state-dependent checks and could lead to runtime panics. Additionally, the use of a nanosecond delay for requeueing in the controller is flagged as non-standard, with a recommendation to use idiomatic requeue flags instead.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 50.01% 50.07% +0.05%
==========================================
Files 86 86
Lines 11178 11262 +84
==========================================
+ Hits 5591 5639 +48
- Misses 4990 5022 +32
- Partials 597 601 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This pull request introduces several updates and refactorings across the project, primarily focusing on CI/CD dependency consolidation and modernizing Kubernetes API and webhook implementations.
Key changes include:
dorny/paths-filter,actions/setup-go,codecov/codecov-action,actions/upload-artifact, andaquasecurity/trivy-action.MCPServer,MCPAccessGrant,MCPAgentSession) with the Kubernetes scheme has been modernized. This involves migrating fromsigs.k8s.io/controller-runtime/pkg/scheme.Buildertok8s.io/apimachinery/pkg/runtime.NewSchemeBuilderand an explicitaddKnownTypesfunction, removing the oldregister.gofile.controller-runtimepatterns. This involves adopting the genericadmission.Defaulterandadmission.Validatorinterfaces and introducing dedicated struct types (mcpServerWebhook,mcpAccessGrantValidator,mcpAgentSessionValidator) for each webhook.MCPServerReconcilernow usesctrl.Result{}for no requeue andctrl.Result{RequeueAfter: time.Nanosecond}for immediate requeues, providing more explicit control over reconciliation flow.controller-runtimemanager options, accommodating recent changes in the library.