feat: add configurable knowledge rules and exit policy - #117
Open
EmersonBraun wants to merge 1 commit into
Open
Conversation
This reverts commit 20ac141.
Member
Author
Code reviewNo blocking issues found in the #104 implementation. The rule engine centralizes policy without duplicating reconciliation, keeps default mode non-blocking, validates configuration before evaluation, supports deterministic severity/ignore/critical-path behavior and CLI exit codes, and leaves existing gate behavior intact. Static centrality is explicitly framed as a review signal rather than runtime availability. Local verification: 237 tests passed, 91.13% statements coverage, typecheck/build passed. |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReconciliationReportV1ak-docs rules run <report.json>with JSON/text output and exit codes 0/1/2Issue
Closes #104
Dependency
This PR is stacked on #116 (
feat/#103-reconciliation).Verification
pnpm typechecknpm test— 237 tests passed, including all plugin contract suitesnpm run coverage— 91.13% statements, 77.71% branches, 95.00% functions, 93.38% linesnpm run build