Fix redispatch bug#2018
Open
cjao wants to merge 2 commits into
Open
Conversation
When the user elects to rerun tasks that haven't changed from the original workflow, only shallow-copy the task definitions and not the generated artifacts to the redispatch b/c the next run will overwrite artifacts from the previous workflow run. Added redispatch test
cjao
force-pushed
the
casey/fix-redispatch
branch
from
8be7b82 to
a5f0da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users redispatch a previously run workflow, the server performs server-side copies of some data from the previous run to the new run to save clients from having to re-upload task definitions that haven't changed from the previous workflow.
In the interest of efficiency, deep copies were changed some time ago to shallow copies (DB references only). Unfortunately, this also introduced a bug as demonstrated by the included test case: unless all functions in the workflow are pure, shallow copies are only safe for immutable artifacts.
Unless the user specifies
reuse_previous_results=True, only shallow-copy task definitions to prevent the next run from overwriting artifacts generated by the previous workflow run.