save proposal from archive node #84

turadg · 2024-01-26T21:28:08Z

closes: #67

The issue was to "validate" but I figured the more valuable cases are "do it for me" and "fix it for me". This adds scripts/add-proposal.ts which does those.

To validate, just save and git diff. If there's a problem, check in the correct version and figure out why SCM didn't have that.

Running the tool revealed that #246 didn't have the bundles from Mainnet, which I missed in review. Not something I could have done without pulling them down, so I think that speaks to the value of the automation in this tool.

changeset-bot · 2025-05-19T23:44:50Z

🦋 Changeset detected

Latest commit: f6e9817

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@agoric/synthetic-chain	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dckc

looks pretty good so far

one suggestion on fetching bundles...

dckc · 2025-05-20T02:30:00Z

packages/synthetic-chain/package.json

-    "@agoric/cosmic-proto": "0.5.0-u18.5",
+    "@agoric/cosmic-proto": "0.4.1-dev-c0e75ad.0",


why bump it backward?

it's actually newer. the SDK release process bumped it, but u18 is older than dev which is every push to master.

fixing that is something Yarn 4 and Changesets will help with

I'm surprised the lerna dev publish doesn't bump versions the same way.

dckc · 2025-05-20T02:36:43Z

packages/synthetic-chain/src/lib/constants.js


-export const CHAINID = NonNullish(process.env.CHAINID);
-export const HOME = NonNullish(process.env.HOME);


so this reduces the scope of HOME? good.

(it still bugs me that we have a file called constants.js that's full of variables.)

dckc · 2025-05-20T14:08:13Z

packages/synthetic-chain/src/cli/chain.ts

+      console.log(
+        'Proposal saved to',
+        submissionDir,
+        '. Now find these bundles and save them there too:',


bundle-tool2 might have some clues to automate this.

provided you have the transaction hash of the bundle upload, the txMessages and getBundle calls in exploreTx should work; that's pretty well tested

to get find the transaction, queryBundleInstalls might work; it's not really used "in anger" though

thanks these were critical clues

so the idea is that the user fetches the bundles in a separate step?

perhaps this message should refer to scripts/fetch-all-bundles.ts?

eek, a bunch of code was lost in rebase. I'll scrounge it up

dckc

looks like forward progress

dckc · 2025-05-27T21:18:45Z

.changeset/gentle-masks-drum.md

+'@agoric/synthetic-chain': patch
+---
+
+remove bankSend agd wrapper


should there be a changeset for the save feature?

it's part of the repo but not what gets a versioned release

dckc · 2025-05-27T21:21:33Z

packages/synthetic-chain/public/upgrade-test-scripts/install_deps.sh

@@ -14,12 +19,10 @@ corepack enable
 cd "$(dirname "$(realpath -- "$0")")"

 # TODO consider yarn workspaces to install all in one command
-if [ -n "$PROPOSAL_PATH" ]; then


my breaking change spidey-sense is tingling.

I presume this is internal, for now.

dckc · 2025-05-27T21:22:36Z

packages/synthetic-chain/src/cli/build.ts

-import { ProposalInfo } from './proposals.js';
+import { type ProposalInfo } from './proposals.js';


note: I wonder why yarn lint didn't catch this earlier.

dckc · 2025-05-27T21:24:19Z

packages/synthetic-chain/src/cli/chain.ts

+export async function saveProposalContents(proposal: ProposalInfo) {
+  assert(isPassed(proposal), 'unpassed propoosals are not on the chain');
+
+  const tm = await makeTendermint34Client(DEFAULT_ARCHIVE_NODE, { fetch });


note: in a follow-on, I'm inclined to try factoring out this ambient authority using some tooling...

SPIKE: inject I/O in multichain helpers using ocap.instructions.md agoric-sdk#11412

dckc · 2025-05-27T21:25:20Z

packages/synthetic-chain/src/cli/chain.ts

+        `${proposal.proposalIdentifier}:${proposal.proposalName}`,
+        'submission',
+      );
+      await fsp.mkdir(submissionDir, { recursive: true });


likewise passing submissionDir as a string rather than an object representing filesystem access

dckc · 2025-05-27T21:31:07Z

packages/synthetic-chain/src/cli/chain.ts

+      console.log(
+        'Proposal saved to',
+        submissionDir,
+        '. Now find these bundles and save them there too:',


so the idea is that the user fetches the bundles in a separate step?

perhaps this message should refer to scripts/fetch-all-bundles.ts?

dckc · 2025-05-27T21:36:09Z

packages/synthetic-chain/src/lib/bundles.ts

+const CACHE_DIR = path.join(
+  process.env.HOME || process.env.USERPROFILE || '',
+  '.agoric',
+  'cache',
+);


Moving this CACHE_DIR calculation up to scripts/fetch-all-bundles.ts would make the data flow more clear (and avoid ambient authority).

I tried it but then it made the cache dir configurable in a way that I didn't want. I also realized it was conflating authority with configuration. What would actually be ocap would be removing fs and path from the bundles module, and creating an ad-hoc powers API for it to use, but I don't think overall that's warranted

dckc

a couple questions

dckc · 2025-05-27T21:58:44Z

scripts/fetch-all-bundles.ts

+import { fetchMsgInstallBundleTxs } from '../src/cli/chain.js';
+import { refreshBundlesCache } from '../src/lib/bundles.js';


How do these imports work?

I don't see a ../src directory.

ah, refactored without testing. will fix

dckc · 2025-05-27T21:59:55Z

scripts/add-proposal.ts

+import fs from 'node:fs';
+import { execSync } from 'node:child_process';
+
+import { saveProposalContents } from '../packages/synthetic-chain/src/cli/chain.ts';


this looks like a cross-package import or something; I'm under the impression that we avoid these, though I don't completely understand why.

This doesn't rely on any undocumented magic, does it?

it's bad if the importing package is published, because the file paths won't necessarily be there in other environments. but these imports are from a repo script which is never published

Co-Authored-By: Dan Connolly <[email protected]>

turadg mentioned this pull request Mar 6, 2024

feat(bundle-cost): reduce by 100x as in mainnet 61 #75

Merged

turadg force-pushed the 67-save-proposal branch from c284b72 to 2c7bf67 Compare May 19, 2025 23:44

turadg requested a review from dckc May 19, 2025 23:45

dckc reviewed May 20, 2025

View reviewed changes

turadg force-pushed the 67-save-proposal branch 2 times, most recently from 9045994 to ef04181 Compare May 20, 2025 20:16

mhofman mentioned this pull request May 21, 2025

Expose some Swingset state through cosmos RPC Agoric/agoric-sdk#9313

Open

turadg force-pushed the 67-save-proposal branch from deb02a6 to ddddbaf Compare May 22, 2025 22:53

turadg requested a review from dckc May 22, 2025 22:55

turadg mentioned this pull request May 26, 2025

feat: add fast-usdc-cctp-beta proposal #246

Merged

3 tasks

turadg added 3 commits May 27, 2025 10:11

chore: assert PROPOSAL_PATH param

11615e9

chore: bump cosmic-proto

d9283ae

fix dependence on env for entry

c88fe01

turadg force-pushed the 67-save-proposal branch from ddddbaf to 305e35d Compare May 27, 2025 20:36

This comment was marked as resolved.

Sign in to view

turadg force-pushed the 67-save-proposal branch from 305e35d to 2627e7b Compare May 27, 2025 20:41

turadg added 2 commits May 27, 2025 13:53

lint: ignore aider files

0868932

feat: executable entrypoint

bc944c2

turadg force-pushed the 67-save-proposal branch from 2627e7b to 171a2c6 Compare May 27, 2025 20:53

turadg requested a review from mujahidkay May 27, 2025 20:56

turadg marked this pull request as ready for review May 27, 2025 20:57

dckc approved these changes May 27, 2025

View reviewed changes

dckc reviewed May 27, 2025

View reviewed changes

turadg added 2 commits May 27, 2025 15:22

lint: ignore all submission files

7db6e23

feat: script to fetch all bundles

6326a12

turadg force-pushed the 67-save-proposal branch from 171a2c6 to 7f8421c Compare May 27, 2025 22:22

turadg enabled auto-merge May 27, 2025 22:22

turadg and others added 2 commits May 27, 2025 15:40

feat: add-proposal script

f8f64ef

Co-Authored-By: Dan Connolly <[email protected]>

chore: add dev deps for types

63518b6

fix: source 94 from mainnet

f6e9817

turadg force-pushed the 67-save-proposal branch from 7f8421c to f6e9817 Compare May 27, 2025 22:41

turadg merged commit 9e15465 into main May 27, 2025
4 checks passed

turadg deleted the 67-save-proposal branch May 27, 2025 23:30

dckc mentioned this pull request May 28, 2025

refactor: inject I/O in fetch-all-bundles.ts, add-proposal.ts #249

Merged

		"@agoric/cosmic-proto": "0.5.0-u18.5",
		"@agoric/cosmic-proto": "0.4.1-dev-c0e75ad.0",


		export const CHAINID = NonNullish(process.env.CHAINID);
		export const HOME = NonNullish(process.env.HOME);

		import { ProposalInfo } from './proposals.js';
		import { type ProposalInfo } from './proposals.js';

		import { fetchMsgInstallBundleTxs } from '../src/cli/chain.js';
		import { refreshBundlesCache } from '../src/lib/bundles.js';

save proposal from archive node #84

save proposal from archive node #84

Uh oh!

Conversation

turadg commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

turadg May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

turadg commented Jan 26, 2024 •

edited

Loading

changeset-bot bot commented May 19, 2025 •

edited

Loading

turadg May 27, 2025 •

edited

Loading