fix CI #7
Open
fix CI #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
turadg
commented
Mar 31, 2025
turadg
commented
- Pull in some changes from upstream
- Remove the vaults job
- Fix formatting
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the CI process by integrating upstream changes, removing the now-unused vaults job, and fixing formatting issues.
- Integration of upstream changes.
- Removal of the vaults job from the CI pipeline.
- Code formatting improvements in key scripts.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/dump-transactions.ts | Formatting optimizations and inlining function parameters. |
| gcp-graphql-pipeline/index.js | Minor whitespace clean-up to support CI updates. |
Files not reviewed (3)
- .github/workflows/vaults-and-reserve-metrics-testing.yml: Language not supported
- package.json: Language not supported
- patches/patch-utf8.sh: Language not supported
samsiegart
approved these changes
Apr 1, 2025
Chris-Hibbert
approved these changes
Apr 1, 2025
.gitignore
Outdated
| @@ -64,3 +64,4 @@ Thumbs.db | |||
| !.yarn/versions | |||
| .aider* | |||
| .env | |||
| .qodo | |||
There was a problem hiding this comment.
What's this suppressing? gemini was no help.
There was a problem hiding this comment.
I dunno either. I took the commit from upstream. benign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.