chore: Monitoring follower unaddressed comments #123
+36
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Mar 14, 2025
…11122) closes: #XXXX refs: #11012 ## Description `agoric install` was broken for dapps after #11012. The reason was the query for workspaces didn't take into account the intended working directory so it always used the directory from which the command was invoked and packages from `agoric-sdk` were never linked ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations Loadgen [build passed](https://github.com/Agoric/testnet-load-generator/actions/runs/13852656508/job/38762668366) using this branch on [#123](Agoric/testnet-load-generator#123) ### Upgrade Considerations None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed comments from #119 which were left unaddressed due to auto merge