Skip to content

Update golang Docker tag to v1.24 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update golang Docker tag to v1.24 #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/production/server-lambda/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# rpm-based image may be better for al2023
FROM --platform=$BUILDPLATFORM golang:1.22-bookworm as builder
FROM --platform=$BUILDPLATFORM golang:1.24-bookworm as builder
ARG TARGETARCH

ENV GOTOOLCHAIN=auto
Expand Down
2 changes: 1 addition & 1 deletion docker/production/server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM golang:1.22-bookworm as builder
FROM --platform=$BUILDPLATFORM golang:1.24-bookworm as builder

Check warning on line 1 in docker/production/server/Dockerfile

View workflow job for this annotation

GitHub Actions / test-docker / build

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
ARG TARGETARCH

ENV GOTOOLCHAIN=auto
Expand All @@ -17,8 +17,8 @@
COPY --from=builder --chown=nonroot:nonroot /opt/app/agricoladb-server /agricoladb-server
COPY --from=builder --chown=nonroot:nonroot /opt/app/agricoladb.sqlite /agricoladb.sqlite

ENV PORT 8000

Check warning on line 20 in docker/production/server/Dockerfile

View workflow job for this annotation

GitHub Actions / test-docker / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
EXPOSE $PORT
ENV DB_PATH /agricoladb.sqlite

Check warning on line 22 in docker/production/server/Dockerfile

View workflow job for this annotation

GitHub Actions / test-docker / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

ENTRYPOINT ["/agricoladb-server"]