Skip to content

Fix missing dotenv for requirements.in #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zackees
Copy link
Contributor

@zackees zackees commented Mar 23, 2025

Request for upstream merge.

My front end tool aicode is reporting that this is a missing dependency when it launches aider.chat in an isolated environment.

I fixed it on my end by forcing dotenv to be included.

Request for upstream merge.

My front end tool aicode is reporting that this is a missing dependency when it launches aider.chat in an isolated environment.

I fixed it on my end by forcing dotenv to be included.
@zackees
Copy link
Contributor Author

zackees commented Mar 25, 2025

let's merge this. easy but critical fix.

@paul-gauthier
Copy link
Collaborator

Thanks for your interest in aider and for taking the time to make this PR.

What is the problem you are trying to solve?

I see python-dotenv is being correctly included as a dependency.

$ grep dotenv requirements.txt
python-dotenv==1.0.1

@zackees
Copy link
Contributor Author

zackees commented Mar 26, 2025

The problem is that the installation is missing the dotenv dependency, and will crash on windows when installed into an isolated environment (in this case my tool aicode, which uses an isolated venv environment (not pipx, uv).

I can also see that it's missing right here in the *.in file here.

It may be transitively pulled in via a sub dependency for certain platforms. I'm not sure why you are seeing it and I'm not.

However, include what you use is not a bad choice in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants