Skip to content

feat: add ability to disable signing git commits #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bedecarroll
Copy link

Adding this flag for two reasons:

  1. If aider is writing the code is it really something you should sign? I feel the user should make that call.
  2. For those of us who use Yubikeys it can be non-obvious as to what the "wait" is when aider has finished a prompt.

I had to modify scripts/update-docs.sh slightly as there were API keys I didn't have but I did not commit the changes.

I used aider to write the unit test checking the change. The command I ran was: uv run -- aider --git-commit-no-sign --read aider/args.py --read aider/repo.py and the prompt was I've added the flag '--git-commit-no-sign' to the code base. Please update the unit tests as per the '--git-commit-verify' flag.

@CLAassistant
Copy link

CLAassistant commented May 12, 2025

CLA assistant check
All committers have signed the CLA.

@peterhadlaw
Copy link
Contributor

Isn't the point of signing the git commit, to mark this commit as authored by "you". If you are writing the code (through the aider tool), you are in fact still responsible for its output.

@bedecarroll
Copy link
Author

Yes but I really think the user should control that via the flag so they can determine the semantics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants