Fix /clear command being undone when switching chat modes #4668
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user runs /clear to clear chat history and then switches to a different chat mode (e.g., /ask, /code, /architect), the cleared history was being restored from the chat history file, effectively undoing the /clear command. Fix by setting restore_chat_history=False when creating a new coder from an existing one. This ensures the new coder respects the current chat state (including cleared history) rather than reloading from disk. The chat history file restoration should only happen on initial startup, not when switching between chat modes within the same session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user runs
/clearto clear chat history and then switches to a different chat mode (e.g.,/ask,/code,/architect), the cleared history was being restored from the chat history file, effectively undoing the /clear command.Fix by setting
restore_chat_history=Falsewhen creating a new coder from an existing one. This ensures the new coder respects the current chat state (including cleared history) rather than reloading from disk.The chat history file restoration should only happen on initial startup, not when switching between chat modes within the same session.