Security: fix critical confirmation bypass, dangerous defaults, and shell injection#5088
Open
johnpippett wants to merge 1 commit intoAider-AI:mainfrom
Open
Security: fix critical confirmation bypass, dangerous defaults, and shell injection#5088johnpippett wants to merge 1 commit intoAider-AI:mainfrom
johnpippett wants to merge 1 commit intoAider-AI:mainfrom
Conversation
…hell injection
- --yes-always bypass: Add explicit_yes_required=True to file creation and
edit confirmations in base_coder.py so --yes cannot auto-approve them.
- Dangerous defaults: Change defaults to False for --auto-accept-architect,
--auto-commits, --dirty-commits, --auto-lint, and --suggest-shell-commands.
- Shell injection:
- commands.py/cmd_git: Use shlex.split + shell=False instead of shell=True.
- editor.py/pipe_editor: Use shlex.split + shell=False.
- commands.py/cmd_run: Add explicit_yes_required confirmation gate before
executing arbitrary shell commands (preserves backward compat for run_cmd).
|
Jack Pippett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple critical security findings identified in an independent security audit:
All existing tests pass (475 passed).